From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1784C282C4 for ; Mon, 4 Feb 2019 22:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D07A2082E for ; Mon, 4 Feb 2019 22:11:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O7NAfIzg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbfBDWLw (ORCPT ); Mon, 4 Feb 2019 17:11:52 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:46027 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726909AbfBDWLw (ORCPT ); Mon, 4 Feb 2019 17:11:52 -0500 Received: by mail-yb1-f193.google.com with SMTP id t11so255887ybi.12 for ; Mon, 04 Feb 2019 14:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AX9mj3vQChg7YilyEA2wXlFmNLFONT5u+xLMENRHxjc=; b=O7NAfIzgMbDZcNneS1BH/o1r04/JDrmkwE5dydOb8LuKSJNLzSpTntwlKJLHKNAtu6 fKKcWZvxV6jrnaZNAMdAmnHbjTT2P7mFM93+bdyDelM99TMHUWDVZ41nwXbd/lozpgwr rfpDMEpXAtmUAz4psxQMM0vumkKfSs5M92cP090gRmJYDl+llNlKj2dcpWN7JKcA82NS 0KXn9t82yFtRETF/M6RkVdQGUgARYyDMBI9CCeqdzkNJYmBmIEGM5DOqqKphwJUYwUXc LR0LXEMmg7HC3I9S8fh8dcZMPoKLi8duja7f84w5xwFn6CgiVc9OIccMjUUwRze9/C8n jNDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AX9mj3vQChg7YilyEA2wXlFmNLFONT5u+xLMENRHxjc=; b=KYWxCr/G9CyaLjlJZujpQYWiKuIO1kMQoOAsQmXkx+iaZgFZt54yCbnpE7gOI44fex OKj5nbOetB6uKXdbIUARdE59FzeFYHJpVCUJAwmZYa3HAjpav53BqsxDUrjMHIa8+Fu/ cw+cU/MpsHklv74i+EizHRE9zZilm/U+sn56IaF93hD/wWfp7JOIALkYKfmKdbW+6fsa lBHBmlRgoZNqRvt7vVI0UuJhUJHVr/O59S1ZgyW1cr8ZPjPKzDq8xpfrDTBxLgIV0Gsy dlI8D7Y4uuClmSoE53ydTMaKB2jkXvCUb3MP32EUDVATQdTQb/e5H4nvK5GphDrfNDPq c/uQ== X-Gm-Message-State: AHQUAubNdx4rKk3ykCGn0rwYa9ioMzspR6rsHJxwn8oQ8fcFVhlJkcUs JosyNTrrRrGOHXuvKz+7Ris= X-Google-Smtp-Source: AHgI3Ia+JZNj/WNuRhECOQcGpwQU9/QPzlqllFdKpTHYiOgt9YJxOpBhvyVGAxM3ZCEXsicH+FnNjQ== X-Received: by 2002:a25:511:: with SMTP id 17mr1430244ybf.158.1549318310669; Mon, 04 Feb 2019 14:11:50 -0800 (PST) Received: from [10.67.48.225] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id s185sm692881yws.69.2019.02.04.14.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 14:11:49 -0800 (PST) Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation To: Christian Lamparter , netdev@vger.kernel.org Cc: Vivien Didelot , Andrew Lunn References: <20190204213555.26054-1-chunkeey@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Mon, 4 Feb 2019 14:11:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190204213555.26054-1-chunkeey@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/4/19 1:35 PM, Christian Lamparter wrote: > The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. > Based on the System Block Diagram in Section 1.2 of the > QCA8337's datasheet. These PHYs are internally connected > to MACs of PORT 1 - PORT 5. However, neither qca8k's slave > mdio access functions qca8k_phy_read()/qca8k_phy_write() > nor the dsa framework is set up for that. > > This version of the patch uses the existing phy-handle > properties of each specified DSA Port in the DT to map > each PORT/MAC to its exposed PHY on the MDIO bus. This > is supported by the current binding document qca8k.txt > as well. I don't think you should have to do any of this translation, because you can do a couple of things with DSA/Device Tree: - you can not provide a phy-handle property at all, in which case, the core DSA layer assumes that the PHY is part of the switch's internal MDIO bus which is implictly created by dsa_slave_mii_bus_create() - you can specify a phy-handle property and then the PHY device tree node can be placed pretty much anywhere in Device Tree, including on a separate MDIO bus Device Tre node which is "external" to the switch In either case, the PHY device's MDIO bus parent and its address are taken care of by drivers/of/of_mdio.c. You can look at mx88e6xxx for how it deals with its internal vs. external MDIO bus controller and that driver is used on a wide variety of cconfiguration. > > Signed-off-by: Christian Lamparter > --- > drivers/net/dsa/qca8k.c | 35 +++++++++++++++++++++++++++++++++-- > 1 file changed, 33 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index a4b6cda38016..6558b7ed855d 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -612,20 +613,50 @@ qca8k_adjust_link(struct dsa_switch *ds, int port, struct phy_device *phy) > qca8k_port_set_status(priv, port, 1); > } > > +static int > +qca8k_to_real_phy(struct dsa_switch *ds, int phy) > +{ > + struct device_node *phy_dn, *port_dn; > + int id; > + > + if (phy >= ds->num_ports) > + return -EINVAL; > + > + port_dn = ds->ports[phy].dn; > + if (!port_dn) > + return -EINVAL; > + > + phy_dn = of_parse_phandle(port_dn, "phy-handle", 0); > + if (!phy_dn) > + return phy; > + > + id = of_mdio_parse_addr(ds->dev, phy_dn); > + of_node_put(phy_dn); > + return id; > +} > + > static int > qca8k_phy_read(struct dsa_switch *ds, int phy, int regnum) > { > struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv; > + int realphy = qca8k_to_real_phy(ds, phy); > + > + if (realphy < 0) > + return realphy; > > - return mdiobus_read(priv->bus, phy, regnum); > + return mdiobus_read(priv->bus, realphy, regnum); > } > > static int > qca8k_phy_write(struct dsa_switch *ds, int phy, int regnum, u16 val) > { > struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv; > + int realphy = qca8k_to_real_phy(ds, phy); > + > + if (realphy < 0) > + return realphy; > > - return mdiobus_write(priv->bus, phy, regnum, val); > + return mdiobus_write(priv->bus, realphy, regnum, val); > } > > static void > -- Florian