From: Matthieu Baerts <matttbe@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: mptcp@lists.linux.dev, "Mat Martineau" <martineau@kernel.org>,
"Geliang Tang" <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Shuah Khan" <shuah@kernel.org>,
"Florian Westphal" <fw@strlen.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
syzbot+455d38ecd5f655fc45cf@syzkaller.appspotmail.com
Subject: Re: [PATCH net 00/15] mptcp: more fixes for the in-kernel PM
Date: Tue, 27 Aug 2024 10:22:02 +0200 [thread overview]
Message-ID: <c832579b-c679-4b28-ab8f-2131ac539c24@kernel.org> (raw)
In-Reply-To: <20240826192955.3dbb469d@kernel.org>
Hi Jakub,
On 27/08/2024 04:29, Jakub Kicinski wrote:
> On Mon, 26 Aug 2024 17:58:59 +0200 Matthieu Baerts (NGI0) wrote:
>> Matthieu Baerts (NGI0) (15):
>> mptcp: pm: reuse ID 0 after delete and re-add
>> mptcp: pm: fix RM_ADDR ID for the initial subflow
>> selftests: mptcp: join: check removing ID 0 endpoint
>> mptcp: pm: send ACK on an active subflow
>> mptcp: pm: skip connecting to already established sf
>> mptcp: pm: reset MPC endp ID when re-added
>> selftests: mptcp: join: check re-adding init endp with != id
>> selftests: mptcp: join: no extra msg if no counter
>> mptcp: pm: do not remove already closed subflows
>> mptcp: pm: fix ID 0 endp usage after multiple re-creations
>> selftests: mptcp: join: check re-re-adding ID 0 endp
>> mptcp: avoid duplicated SUB_CLOSED events
>> selftests: mptcp: join: validate event numbers
>> mptcp: pm: ADD_ADDR 0 is not a new address
>> selftests: mptcp: join: check re-re-adding ID 0 signal
>
> The debug runner is failing mptcp-join-sh fairly consistently with
> these applied :(
Thank you for this notification!
It looks like the patch "selftests: mptcp: join: check re-re-adding ID 0
endp" is making the "delete and re-add" subtest longer: the connection
finishes while the validation is still ongoing. I guess I didn't see
this issue on my side, nor on MPTCP CI, because the Netdev CI is slower
(SLUB_DEBUG_ON?).
It is easy to fix, but I will wait for the other MPTCP series to be
applied, before sending a v2.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-08-27 8:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 15:58 [PATCH net 00/15] mptcp: more fixes for the in-kernel PM Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 01/15] mptcp: pm: reuse ID 0 after delete and re-add Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 02/15] mptcp: pm: fix RM_ADDR ID for the initial subflow Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 03/15] selftests: mptcp: join: check removing ID 0 endpoint Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 04/15] mptcp: pm: send ACK on an active subflow Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 05/15] mptcp: pm: skip connecting to already established sf Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 06/15] mptcp: pm: reset MPC endp ID when re-added Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 07/15] selftests: mptcp: join: check re-adding init endp with != id Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 08/15] selftests: mptcp: join: no extra msg if no counter Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 09/15] mptcp: pm: do not remove already closed subflows Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 10/15] mptcp: pm: fix ID 0 endp usage after multiple re-creations Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 11/15] selftests: mptcp: join: check re-re-adding ID 0 endp Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 12/15] mptcp: avoid duplicated SUB_CLOSED events Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 13/15] selftests: mptcp: join: validate event numbers Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 14/15] mptcp: pm: ADD_ADDR 0 is not a new address Matthieu Baerts (NGI0)
2024-08-26 15:59 ` [PATCH net 15/15] selftests: mptcp: join: check re-re-adding ID 0 signal Matthieu Baerts (NGI0)
2024-08-27 2:29 ` [PATCH net 00/15] mptcp: more fixes for the in-kernel PM Jakub Kicinski
2024-08-27 8:22 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c832579b-c679-4b28-ab8f-2131ac539c24@kernel.org \
--to=matttbe@kernel.org \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+455d38ecd5f655fc45cf@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).