From: Matthieu Baerts <matttbe@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: move wait_local_port_listen to lib.sh
Date: Fri, 23 May 2025 12:56:01 +0200 [thread overview]
Message-ID: <c8455e63-4c25-4610-bfbf-f6547b3ac834@kernel.org> (raw)
In-Reply-To: <20250523034433.1373-1-liuhangbin@gmail.com>
Hi Hangbin,
On 23/05/2025 05:44, Hangbin Liu wrote:
> The function wait_local_port_listen() is the only function defined in
> net_helper.sh. Since some tests source both lib.sh and net_helper.sh,
> we can simplify the setup by moving wait_local_port_listen() to lib.sh.
>
> With this change, net_helper.sh becomes redundant and can be removed.
Thank you for the modifications! I wanted to do the same at some points,
then I forgot :)
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/net/busy_poll_test.sh | 2 +-
> .../net/ipv6_route_update_soft_lockup.sh | 1 -
> tools/testing/selftests/net/lib.sh | 21 ++++++++++++++++
> tools/testing/selftests/net/mptcp/Makefile | 2 +-
> .../testing/selftests/net/mptcp/mptcp_lib.sh | 1 -
> tools/testing/selftests/net/net_helper.sh | 25 -------------------
> tools/testing/selftests/net/pmtu.sh | 1 -
> tools/testing/selftests/net/udpgro.sh | 2 +-
> tools/testing/selftests/net/udpgro_bench.sh | 2 +-
> tools/testing/selftests/net/udpgro_frglist.sh | 2 +-
> tools/testing/selftests/net/udpgro_fwd.sh | 2 +-
> 12 files changed, 28 insertions(+), 35 deletions(-)
> delete mode 100644 tools/testing/selftests/net/net_helper.sh
The changes in MPTCP and others look good to me, except that I think you
forgot to modify files in tools/testing/selftests/drivers/net as well:
> tools/testing/selftests/drivers/net/Makefile: ../../net/net_helper.sh \
> tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh:source "${LIBDIR}"/../../../../net/net_helper.sh
> tools/testing/selftests/drivers/net/netdevsim/peer.sh:source ../../../net/net_helper.sh
pw-bot: cr
Note that the "netdev/check_selftest" NIPA check will not handle this
case where a shell script is removed. But that's OK, it can be ignored.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-05-23 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 3:44 [PATCH net-next] selftests: net: move wait_local_port_listen to lib.sh Hangbin Liu
2025-05-23 10:56 ` Matthieu Baerts [this message]
2025-05-23 11:21 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8455e63-4c25-4610-bfbf-f6547b3ac834@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).