From: Robin Murphy <robin.murphy@arm.com>
To: "Leonidas P. Papadakos" <papadakospan@gmail.com>,
Jose Abreu <jose.abreu@synopsys.com>
Cc: "Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Christoph Müllner" <christoph.muellner@theobroma-systems.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Klaus Goger" <klaus.goger@theobroma-systems.com>
Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices
Date: Wed, 3 Apr 2019 17:12:03 +0100 [thread overview]
Message-ID: <c863f88a-65e2-4093-7cc1-f37e4443b871@arm.com> (raw)
In-Reply-To: <1554306954.1328.1@gmail.com>
On 03/04/2019 16:55, Leonidas P. Papadakos wrote:
>
>> If snps,no-pbl-x8 does indeed have a performace hit, should the
>> workaround be to
>> a) turn tx checksumming off or
>> b) snps,no-pbl-x8 set?
>>
>> I'll test to see the difference
>
> Update: It really seems like snps,no-pbl-x8 is the better option.
> So I say, replace snps,force_thresh_dma_mode with it.
Yes, I would expect software checksumming to have a much more noticeable
impact (in fact I've already been trying to get round to benchmarking
some arm64 checksum optimisations on my RK3328 precisely because of this
issue).
If I'm interpreting the register descriptions in the Rockchip TRMs
correctly, it seems like no-pbl-x8 is a relatively big hammer and there
should still be room to tune things a bit closer to the maximum limits -
I'll have another play this evening to see if I've understood things right.
Robin.
next prev parent reply other threads:[~2019-04-03 16:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 18:18 [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices Leonidas P. Papadakos
2019-04-01 18:31 ` Heiko Stübner
2019-04-01 18:54 ` Robin Murphy
2019-04-01 19:06 ` Heiko Stübner
2019-04-01 19:12 ` Philipp Tomsich
2019-04-02 7:59 ` Jose Abreu
2019-04-02 11:49 ` Robin Murphy
2019-04-02 11:53 ` Jose Abreu
2019-04-02 22:08 ` Robin Murphy
2019-04-02 22:48 ` Leonidas P. Papadakos
2019-04-03 7:55 ` Jose Abreu
2019-04-03 15:35 ` Leonidas P. Papadakos
2019-04-03 15:55 ` Leonidas P. Papadakos
2019-04-03 16:12 ` Robin Murphy [this message]
2019-04-05 10:24 ` Jose Abreu
2019-04-05 17:58 ` Leonidas P. Papadakos
2019-04-05 18:14 ` Leonidas P. Papadakos
2019-04-05 18:29 ` Robin Murphy
2019-04-05 18:38 ` Leonidas P. Papadakos
2019-04-11 21:09 ` Leonidas P. Papadakos
2019-04-12 7:35 ` Jose Abreu
2019-04-12 11:13 ` Leonidas P. Papadakos
2019-04-15 8:15 ` Jose Abreu
2019-04-15 21:45 ` Leonidas P. Papadakos
2019-04-15 22:19 ` Leonidas P. Papadakos
2019-04-16 8:01 ` Jose Abreu
2019-04-16 10:03 ` Leonidas P. Papadakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c863f88a-65e2-4093-7cc1-f37e4443b871@arm.com \
--to=robin.murphy@arm.com \
--cc=alexandre.torgue@st.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=jose.abreu@synopsys.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=papadakospan@gmail.com \
--cc=philipp.tomsich@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).