From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour
Date: Mon, 28 Sep 2020 18:46:14 -0700 [thread overview]
Message-ID: <c877bda0-140c-dce1-49ff-61fac47a66bc@gmail.com> (raw)
In-Reply-To: <20200928163936.1bdacb89@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 9/28/2020 4:39 PM, Jakub Kicinski wrote:
> On Mon, 28 Sep 2020 15:36:50 -0700 Florian Fainelli wrote:
>> On 9/28/2020 3:35 PM, Jakub Kicinski wrote:
>>> On Tue, 29 Sep 2020 00:07:30 +0200 Andrew Lunn wrote:
>>>> On Mon, Sep 28, 2020 at 10:05:08PM +0000, Vladimir Oltean wrote:
>>>>> On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski wrote:
>>>>>> On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote:
>>>>>>> Not all ports of a switch need to be used, particularly in embedded
>>>>>>> systems. Add a port flavour for ports which physically exist in the
>>>>>>> switch, but are not connected to the front panel etc, and so are
>>>>>>> unused.
>>>>>>
>>>>>> This is missing the explanation of why reporting such ports makes sense.
>>>>>
>>>>> Because this is a core devlink patch, we're talking really generalistic
>>>>> here.
>>>>
>>>> Hi Vladimir
>>>>
>>>> I don't think Jakub is questioning the why. He just wants it in the
>>>> commit message.
>>>
>>> Ack, I think we need to clearly say when those should be exposed.
>>> Most ASICs will have disabled ports, and we don't expect NICs to
>>> suddenly start reporting ports for all PCI PFs they may have.
>>>
>>> Also I keep thinking that these ports and all their objects should
>>> be hidden under some switch from user space perspective because they
>>> are unlikely to be valuable to see for a normal user. Thoughts?
>>
>> Hidden in what sense? They are already hidden in that there is no
>> net_device object being created for them. Are you asking for adding
>> another option to say, devlink show like:
>>
>> devlink show -a
>>
>> which would also show the ports that are disabled during a dump?
>
> Yup, exactly. Looks like ip uses -a for something I don't quite
> understand - but some switch along those lines. We already have
> -d for hiding less-relevant attributes.
>
> Do you think this is an overkill? I don't feel strongly.
That makes sense to me as it would be confusing to suddenly show unused
port flavors after this patch series land. Andrew, Vladimir, does that
work for you as well?
--
Florian
next prev parent reply other threads:[~2020-09-29 1:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 21:06 [PATCH net-next v2 0/7] mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 1/7] net: devlink: Add unused port flavour Andrew Lunn
2020-09-26 21:51 ` Vladimir Oltean
2020-09-26 22:00 ` Vladimir Oltean
2020-09-27 0:33 ` Andrew Lunn
2020-09-28 21:31 ` Jakub Kicinski
2020-09-28 22:05 ` Vladimir Oltean
2020-09-28 22:07 ` Andrew Lunn
2020-09-28 22:35 ` Jakub Kicinski
2020-09-28 22:36 ` Florian Fainelli
2020-09-28 23:39 ` Jakub Kicinski
2020-09-29 1:46 ` Florian Fainelli [this message]
2020-09-29 11:03 ` Vladimir Oltean
2020-09-29 13:07 ` Jiri Pirko
2020-09-29 13:48 ` Vladimir Oltean
2020-09-29 15:12 ` Jiri Pirko
2020-09-29 13:57 ` Andrew Lunn
2020-09-30 6:56 ` Jiri Pirko
2020-09-30 13:57 ` Andrew Lunn
2020-09-30 14:34 ` Jiri Pirko
2020-09-30 14:53 ` Andrew Lunn
2020-10-01 7:39 ` Jiri Pirko
2020-09-26 21:06 ` [PATCH net-next v2 2/7] net: dsa: Make use of devlink port flavour unused Andrew Lunn
2020-09-26 22:51 ` Vladimir Oltean
2020-09-26 21:06 ` [PATCH net-next v2 3/7] net: dsa: Register devlink ports before calling DSA driver setup() Andrew Lunn
2020-09-26 23:37 ` Vladimir Oltean
2020-09-27 0:45 ` Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 4/7] net: devlink: Add support for port regions Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 5/7] net: dsa: Add devlink port regions support to DSA Andrew Lunn
2020-09-26 23:42 ` Vladimir Oltean
2020-09-26 21:06 ` [PATCH net-next v2 6/7] net: dsa: Add helper for converting devlink port to ds and port Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-09-26 23:52 ` Vladimir Oltean
2020-09-27 1:03 ` Andrew Lunn
2020-09-27 1:11 ` Vladimir Oltean
2020-09-26 22:02 ` [PATCH net-next v2 0/7] " Marek Behun
2020-09-26 22:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c877bda0-140c-dce1-49ff-61fac47a66bc@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).