Re: [PATCH net-next v6 4/5] ice: add ability to read and configure FW log data

[Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>]

On 12/14/2023 2:12 PM, Keller, Jacob E wrote:
> 
> 
>> -----Original Message-----
>> From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
>> Sent: Thursday, December 14, 2023 11:41 AM
>> To: davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com;
>> edumazet@google.com; netdev@vger.kernel.org
>> Cc: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Nguyen, Anthony L
>> <anthony.l.nguyen@intel.com>; Keller, Jacob E <jacob.e.keller@intel.com>;
>> Tipireddy, Vaishnavi <vaishnavi.tipireddy@intel.com>; horms@kernel.org;
>> leon@kernel.org; Pucha, HimasekharX Reddy
>> <himasekharx.reddy.pucha@intel.com>
>> Subject: [PATCH net-next v6 4/5] ice: add ability to read and configure FW log data
> ...
> 
>> +/* the order in this array is important. it matches the ordering of the
>> + * values in the FW so the index is the same value as in ice_fwlog_level
>> + */
>> +static const char * const ice_fwlog_log_size[] = {
>> +	"128K",
>> +	"256K",
>> +	"512K",
>> +	"1M",
>> +	"2M",
>> +};
> 
> The comment feels like a copy paste. The size should only matter for software and shouldn't have anything to do with he firmware as this is just the size of the buffer we'll allocate to store into?
> 

Yeah, not sure how that got in there...

> Thanks,
> Jake