From mboxrd@z Thu Jan 1 00:00:00 1970 From: Venkat Venkatsubra Subject: Re: [PATCH] RDSRDMA: Fix cleanup of rds_iw_mr_pool Date: Thu, 29 Sep 2011 11:51:47 -0700 (PDT) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: , To: Return-path: Received: from rcsinet15.oracle.com ([148.87.113.117]:37496 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754681Ab1I2Sv7 convert rfc822-to-8bit (ORCPT ); Thu, 29 Sep 2011 14:51:59 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: In the rds_iw_mr_pool struct the free_pinned field keeps track of memory pinned by free MRs. While this field is incremented properly upon allocation, it is never decremented upon unmapping. This would cause the rds_rdma module to crash the kernel upon unloading, by triggering the BUG_ON in the rds_iw_destroy_mr_pool function. This change keeps track of the MRs that become unpinned, so that free_pinned can be decremented appropriately. Signed-off-by: Jonathan Lallinger Signed-off-by: Steve Wise --- Signed-off-by: Venkat Venkatsubra Venkat