From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload Date: Fri, 1 Dec 2017 11:23:18 -0800 Message-ID: References: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> <1511862571-3494-3-git-send-email-yossefe@mellanox.com> <20171201062321.dt3jbrfs4svwpgqx@gauss3.secunet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, borisp@mellanox.com, kliteyn@mellanox.com, yossiku@mellanox.com To: Steffen Klassert , yossefe@mellanox.com Return-path: In-Reply-To: <20171201062321.dt3jbrfs4svwpgqx@gauss3.secunet.de> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/30/2017 10:23 PM, Steffen Klassert wrote: > On Tue, Nov 28, 2017 at 11:49:30AM +0200, yossefe@mellanox.com wrote: >> From: Yossef Efraim >> >> This patch adds ESN support to IPsec device offload. >> Adding new xfrm device operation to synchronize device ESN. >> >> Signed-off-by: Yossef Efraim >> --- >> include/linux/netdevice.h | 1 + >> include/net/xfrm.h | 12 ++++++++++++ >> net/xfrm/xfrm_device.c | 4 ++-- >> net/xfrm/xfrm_replay.c | 2 ++ >> 4 files changed, 17 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index 7de7656..d4e9198 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h >> @@ -825,6 +825,7 @@ struct xfrmdev_ops { >> void (*xdo_dev_state_free) (struct xfrm_state *x); >> bool (*xdo_dev_offload_ok) (struct sk_buff *skb, >> struct xfrm_state *x); >> + void (*xdo_dev_state_advance_esn) (struct xfrm_state *x); > > We now have a documentation for the xfrm offloadin API in the > ipsec-next tree. Please document the new device operation > there and resubmit. Please be sure to specify what the offloading driver is expected to do with this. sln > > Thanks! >