From: Florian Fainelli <f.fainelli@gmail.com>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: netdev <netdev@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"N, Mugunthan V" <mugunthanvnm@ti.com>,
Rami Rosen <roszenrami@gmail.com>
Subject: Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers
Date: Wed, 23 Nov 2016 12:15:46 -0800 [thread overview]
Message-ID: <c91dcd74-3983-3ab6-91f6-3657b1e601af@gmail.com> (raw)
In-Reply-To: <CAGm1_ksC_6afhzK39uVTSk2PoC9CrR4Fow89YCZfihS2f6wzOw@mail.gmail.com>
On 11/23/2016 12:08 PM, Yegor Yefremov wrote:
> On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 11/23/2016 06:38 AM, yegorslists@googlemail.com wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> Add the ability to query and set Energy Efficient Ethernet parameters
>>> via ethtool for applicable devices.
>>
>> Are you sure this is enough to actually enable EEE? I don't see where
>> phy_init_eee() is called here, nor is the cpsw Ethernet controller part
>> configured to enable/disable EEE. EEE is not just a PHY thing, it
>> usually also needs to be configured properly at the Ethernet MAC/switch
>> level as well.
>>
>> Just curious here.
>
> I'm sure I want to disable EEE :-) So I need this patch in order to
> check and disable EEE advertising.
OK, so you need this to disable EEE advertisement, which is great, but
this also allows you to enable EEE, is it enough to just advertise EEE
with your link partner for cpsw to work correctly? Just wondering, since
your commit message is more than short.
--
Florian
next prev parent reply other threads:[~2016-11-23 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 14:38 [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers yegorslists
2016-11-23 14:47 ` Rami Rosen
2016-11-23 17:33 ` Florian Fainelli
2016-11-23 20:08 ` Yegor Yefremov
2016-11-23 20:15 ` Florian Fainelli [this message]
2016-11-24 9:25 ` Yegor Yefremov
2016-11-24 15:38 ` Andrew Lunn
2016-11-24 18:23 ` Florian Fainelli
2016-12-02 9:11 ` Giuseppe CAVALLARO
2016-12-02 17:48 ` Florian Fainelli
2017-01-04 14:33 ` Florian Fainelli
2017-04-18 13:23 ` Niklas Cassel
2017-04-18 16:40 ` Florian Fainelli
2017-04-25 9:06 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91dcd74-3983-3ab6-91f6-3657b1e601af@gmail.com \
--to=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=roszenrami@gmail.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).