From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: dev_loopback_xmit parameters Date: Mon, 23 Apr 2018 15:36:03 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit To: Emanuele , Linux Kernel Network Developers Return-path: Received: from mail-pf0-f177.google.com ([209.85.192.177]:41626 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932514AbeDWWgG (ORCPT ); Mon, 23 Apr 2018 18:36:06 -0400 Received: by mail-pf0-f177.google.com with SMTP id v63so919994pfk.8 for ; Mon, 23 Apr 2018 15:36:06 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 04/23/2018 02:40 PM, Emanuele wrote: > Hello, > > I don't know if this is the right place where to ask, but I was wondering why the dev_loopback_xmit function defined in /net/core/dev.c takes struct net * and struct sock *  as parameters. They are never used, so I believe passing only the struct  sk_buff * should be enough. > Look at net/ipv6/ip6_output.c where NF_HOOK() uses dev_loopback_xmit(). > In addition, it would like to know where I can read what is and how to set a skb dst_entry, since I don't really understand it. > > Thanks a lot, > > Emanuele >