From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shannon Nelson <shannon.nelson@oracle.com>
Subject: Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free
Date: Thu, 14 Dec 2017 08:28:17 -0800
Message-ID: <c938dafb-e2a8-ff75-4ef3-cbd1ea62f8dc@oracle.com>
References: <1513025842-12064-1-git-send-email-shannon.nelson@oracle.com>
 <20171214062020.wj6iglgcfpu2b7kh@gauss3.secunet.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Steffen Klassert <steffen.klassert@secunet.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from userp2120.oracle.com ([156.151.31.85]:56442 "EHLO
        userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753013AbdLNQ3j (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 14 Dec 2017 11:29:39 -0500
In-Reply-To: <20171214062020.wj6iglgcfpu2b7kh@gauss3.secunet.de>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 12/13/2017 10:20 PM, Steffen Klassert wrote:
> On Mon, Dec 11, 2017 at 12:57:22PM -0800, Shannon Nelson wrote:
>> The current XFRM code assumes that we've implemented the
>> xdo_dev_state_free() callback, even if it is meaningless to the driver.

<snip>

>> +		if (dev->features & NETIF_F_HW_ESP_TX_CSUM) {
>> +			netdev_err(dev, "NETIF_F_HW_ESP_TX_CSUM without NETIF_F_HW_ESP\n");
>> +			return NOTIFY_BAD;
>> +		} else {
>> +			return NOTIFY_DONE;
>> +		}
>> +	}
>> +
>> +	if (!(dev->xfrmdev_ops &&
>> +	      dev->xfrmdev_ops->xdo_dev_state_add &&
>> +	      dev->xfrmdev_ops->xdo_dev_state_delete)) {
>> +		netdev_err(dev, "add or delete function missing from xfrmdev_ops\n");
> 
> Please remove these error printings, this is not relevant for normal
> users.
> 

Okay.

After I posted this I realized this really should be two patches, so 
I'll split this up as well before resending.

sln