* [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value
@ 2022-04-21 10:12 Clément Léger
2022-04-21 10:17 ` Nikolay Aleksandrov
2022-04-22 22:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Clément Léger @ 2022-04-21 10:12 UTC (permalink / raw)
To: Roopa Prabhu, Nikolay Aleksandrov, David S. Miller,
Jakub Kicinski, Paolo Abeni, Tobias Waldekranz
Cc: bridge, netdev, linux-kernel, Clément Léger
br_vlan_group() can return NULL and thus return value must be checked
to avoid dereferencing a NULL pointer.
Fixes: 6284c723d9b9 ("net: bridge: mst: Notify switchdev drivers of VLAN MSTI migrations")
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
net/bridge/br_switchdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
index 81400e0b26ac..8f3d76c751dd 100644
--- a/net/bridge/br_switchdev.c
+++ b/net/bridge/br_switchdev.c
@@ -354,6 +354,8 @@ static int br_switchdev_vlan_attr_replay(struct net_device *br_dev,
attr.orig_dev = br_dev;
vg = br_vlan_group(br);
+ if (!vg)
+ return 0;
list_for_each_entry(v, &vg->vlan_list, vlist) {
if (v->msti) {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value
2022-04-21 10:12 [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value Clément Léger
@ 2022-04-21 10:17 ` Nikolay Aleksandrov
2022-04-22 22:14 ` Jakub Kicinski
2022-04-22 22:20 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Nikolay Aleksandrov @ 2022-04-21 10:17 UTC (permalink / raw)
To: Clément Léger, Roopa Prabhu, David S. Miller,
Jakub Kicinski, Paolo Abeni, Tobias Waldekranz
Cc: bridge, netdev, linux-kernel
On 21/04/2022 13:12, Clément Léger wrote:
> br_vlan_group() can return NULL and thus return value must be checked
> to avoid dereferencing a NULL pointer.
>
> Fixes: 6284c723d9b9 ("net: bridge: mst: Notify switchdev drivers of VLAN MSTI migrations")
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
> net/bridge/br_switchdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
> index 81400e0b26ac..8f3d76c751dd 100644
> --- a/net/bridge/br_switchdev.c
> +++ b/net/bridge/br_switchdev.c
> @@ -354,6 +354,8 @@ static int br_switchdev_vlan_attr_replay(struct net_device *br_dev,
> attr.orig_dev = br_dev;
>
> vg = br_vlan_group(br);
> + if (!vg)
> + return 0;
>
> list_for_each_entry(v, &vg->vlan_list, vlist) {
> if (v->msti) {
Good catch.
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value
2022-04-21 10:17 ` Nikolay Aleksandrov
@ 2022-04-22 22:14 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-04-22 22:14 UTC (permalink / raw)
To: Nikolay Aleksandrov
Cc: Clément Léger, Roopa Prabhu, David S. Miller,
Paolo Abeni, Tobias Waldekranz, bridge, netdev, linux-kernel
On Thu, 21 Apr 2022 13:17:51 +0300 Nikolay Aleksandrov wrote:
> On 21/04/2022 13:12, Clément Léger wrote:
> > br_vlan_group() can return NULL and thus return value must be checked
> > to avoid dereferencing a NULL pointer.
> >
> > Fixes: 6284c723d9b9 ("net: bridge: mst: Notify switchdev drivers of VLAN MSTI migrations")
> > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> > ---
> > net/bridge/br_switchdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
> > index 81400e0b26ac..8f3d76c751dd 100644
> > --- a/net/bridge/br_switchdev.c
> > +++ b/net/bridge/br_switchdev.c
> > @@ -354,6 +354,8 @@ static int br_switchdev_vlan_attr_replay(struct net_device *br_dev,
> > attr.orig_dev = br_dev;
> >
> > vg = br_vlan_group(br);
> > + if (!vg)
> > + return 0;
> >
> > list_for_each_entry(v, &vg->vlan_list, vlist) {
> > if (v->msti) {
>
> Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Thanks! Applying to net tho, the patch in question is already
in Linus's tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value
2022-04-21 10:12 [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value Clément Léger
2022-04-21 10:17 ` Nikolay Aleksandrov
@ 2022-04-22 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-22 22:20 UTC (permalink / raw)
To: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2VyIDxjbGVtZW50LmxlZ2VyQGJvb3RsaW4uY29tPg==?=
Cc: roopa, razor, davem, kuba, pabeni, tobias, bridge, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 21 Apr 2022 12:12:47 +0200 you wrote:
> br_vlan_group() can return NULL and thus return value must be checked
> to avoid dereferencing a NULL pointer.
>
> Fixes: 6284c723d9b9 ("net: bridge: mst: Notify switchdev drivers of VLAN MSTI migrations")
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
> net/bridge/br_switchdev.c | 2 ++
> 1 file changed, 2 insertions(+)
Here is the summary with links:
- [net-next] net: bridge: switchdev: check br_vlan_group() return value
https://git.kernel.org/netdev/net/c/7f40ea2145d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-22 22:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-21 10:12 [PATCH net-next] net: bridge: switchdev: check br_vlan_group() return value Clément Léger
2022-04-21 10:17 ` Nikolay Aleksandrov
2022-04-22 22:14 ` Jakub Kicinski
2022-04-22 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).