netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Serhey Popovych <serhe.popovych@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next v2 0/8] ip: Introduce and use get_addr_rta()/inet_addr_match_rta()
Date: Tue, 23 Jan 2018 20:45:14 -0700	[thread overview]
Message-ID: <c9534eae-f757-47a4-8d12-5f33b57f61fe@gmail.com> (raw)
In-Reply-To: <1516735170-20921-1-git-send-email-serhe.popovych@gmail.com>

On 1/23/18 12:19 PM, Serhey Popovych wrote:
> Now we enhance get_addr() to return additional
> information about address (e.g. if it unspecified
> or multicast) we want to have same functionality
> for attributes in netlink message.
> 
> Introduce and use get_addr_rta() that parses
> given netlink attribute into @inet_prefix
> data structure in the same way similar get_addr()
> parses address from it's string representation.
> 
> Use attribute length to guess address family:
> force it by giving non AF_UNSPEC @family to
> get_addr_rta() to ensure address is of expected
> family.
> 
> Introduce and use inet_addr_match_rta() to further
> simplify and unify code where get_addr_rta()
> intended to be used together with inet_addr_match().
> 
> This is next step in ipv4 and ipv6 modules
> unification to prepare for merge in the future.
> 
> Any comments, suggestions and criticism as always
> welcome.

No need to resend this set, but in the future your commit messages can
use say 72 characters per line. You seem to be line wrapping between 50
and 60 characters.

      parent reply	other threads:[~2018-01-24  3:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 19:19 [PATCH iproute2-next v2 0/8] ip: Introduce and use get_addr_rta()/inet_addr_match_rta() Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 1/8] utils: Introduce get_addr_rta() and inet_addr_match_rta() Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 2/8] ipaddress: Use inet_addr_match_rta() Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 3/8] iprule: " Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 4/8] ipmroute: " Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 5/8] ipneigh: " Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 6/8] ipl2tp: Use get_addr_rta() Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 7/8] tcp_metric: " Serhey Popovych
2018-01-23 19:19 ` [PATCH iproute2-next v2 8/8] ip/tunnel: Unify local/remote endpoint address printing Serhey Popovych
2018-01-24 18:40   ` David Ahern
2018-01-24  3:45 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9534eae-f757-47a4-8d12-5f33b57f61fe@gmail.com \
    --to=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=serhe.popovych@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).