From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next v2 0/8] ip: Introduce and use get_addr_rta()/inet_addr_match_rta() Date: Tue, 23 Jan 2018 20:45:14 -0700 Message-ID: References: <1516735170-20921-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Serhey Popovych , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f50.google.com ([74.125.83.50]:38973 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbeAXDpJ (ORCPT ); Tue, 23 Jan 2018 22:45:09 -0500 Received: by mail-pg0-f50.google.com with SMTP id w17so1790876pgv.6 for ; Tue, 23 Jan 2018 19:45:08 -0800 (PST) In-Reply-To: <1516735170-20921-1-git-send-email-serhe.popovych@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/23/18 12:19 PM, Serhey Popovych wrote: > Now we enhance get_addr() to return additional > information about address (e.g. if it unspecified > or multicast) we want to have same functionality > for attributes in netlink message. > > Introduce and use get_addr_rta() that parses > given netlink attribute into @inet_prefix > data structure in the same way similar get_addr() > parses address from it's string representation. > > Use attribute length to guess address family: > force it by giving non AF_UNSPEC @family to > get_addr_rta() to ensure address is of expected > family. > > Introduce and use inet_addr_match_rta() to further > simplify and unify code where get_addr_rta() > intended to be used together with inet_addr_match(). > > This is next step in ipv4 and ipv6 modules > unification to prepare for merge in the future. > > Any comments, suggestions and criticism as always > welcome. No need to resend this set, but in the future your commit messages can use say 72 characters per line. You seem to be line wrapping between 50 and 60 characters.