From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: Taehee Yoo <ap420073@gmail.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <pabeni@redhat.com>, <edumazet@google.com>,
<corbet@lwn.net>, <michael.chan@broadcom.com>,
<netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>
Cc: <ecree.xilinx@gmail.com>, <przemyslaw.kitszel@intel.com>,
<andrew@lunn.ch>, <hkallweit1@gmail.com>,
<kory.maincent@bootlin.com>, <ahmed.zaki@intel.com>,
<paul.greenwalt@intel.com>, <rrameshbabu@nvidia.com>,
<idosch@nvidia.com>, <maxime.chevallier@bootlin.com>,
<danieller@nvidia.com>, <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next v2 3/4] ethtool: Add support for configuring tcp-data-split-thresh
Date: Wed, 11 Sep 2024 11:51:42 -0500 [thread overview]
Message-ID: <c970e22e-9fcc-499a-8c83-32b41439cbb9@intel.com> (raw)
In-Reply-To: <20240911145555.318605-4-ap420073@gmail.com>
On 9/11/2024 9:55 AM, Taehee Yoo wrote:
> The tcp-data-split-thresh option configures the threshold value of
> the tcp-data-split.
> If a received packet size is larger than this threshold value, a packet
> will be split into header and payload.
> The header indicates TCP header, but it depends on driver spec.
> The bnxt_en driver supports HDS(Header-Data-Split) configuration at
> FW level, affecting TCP and UDP too.
> So, like the tcp-data-split option, If tcp-data-split-thresh is set,
> it affects UDP and TCP packets.
What about non-tcp/udp packets? Are they are not split?
It is possible that they may be split at L3 payload for IP/IPV6 packets
and L2 payload for non-ip packets.
So instead of calling this option as tcp-data-split-thresh, can we call
it header-data-split-thresh?
>
> The tcp-data-split-thresh has a dependency, that is tcp-data-split
> option. This threshold value can be get/set only when tcp-data-split
> option is enabled.
Even the existing 'tcp-data-split' name is misleading. Not sure if it
will be possible to change this now.
next prev parent reply other threads:[~2024-09-11 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:55 [PATCH net-next v2 0/4] bnxt_en: implement tcp-data-split ethtool command Taehee Yoo
2024-09-11 14:55 ` [PATCH net-next v2 1/4] bnxt_en: add support for rx-copybreak " Taehee Yoo
2024-09-11 15:36 ` Brett Creeley
2024-09-11 15:53 ` Taehee Yoo
2024-09-12 0:22 ` Jakub Kicinski
2024-09-12 0:47 ` Michael Chan
2024-09-11 14:55 ` [PATCH net-next v2 2/4] bnxt_en: add support for tcp-data-split " Taehee Yoo
2024-09-11 14:55 ` [PATCH net-next v2 3/4] ethtool: Add support for configuring tcp-data-split-thresh Taehee Yoo
2024-09-11 15:26 ` Kory Maincent
2024-09-11 15:42 ` Taehee Yoo
2024-09-11 15:47 ` Brett Creeley
2024-09-11 16:03 ` Taehee Yoo
2024-09-11 16:06 ` Brett Creeley
2024-09-11 16:51 ` Samudrala, Sridhar [this message]
2024-09-12 0:31 ` Jakub Kicinski
2024-09-12 15:42 ` Samudrala, Sridhar
2024-09-11 14:55 ` [PATCH net-next v2 4/4] bnxt_en: add support for tcp-data-split-thresh ethtool command Taehee Yoo
2024-09-11 15:52 ` Brett Creeley
2024-09-11 16:32 ` Taehee Yoo
2024-09-11 17:34 ` Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c970e22e-9fcc-499a-8c83-32b41439cbb9@intel.com \
--to=sridhar.samudrala@intel.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@nvidia.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).