From: Andrew Lunn <andrew@lunn.ch>
To: Ravi Gunasekaran <r-gunasekaran@ti.com>
Cc: Lukasz Majewski <lukma@denx.de>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Eric Dumazet <edumazet@google.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Tristram.Ha@microchip.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Paolo Abeni <pabeni@redhat.com>,
Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
Murali Karicheri <m-karicheri2@ti.com>,
Ziyang Xuan <william.xuanziyang@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hsr: Use full string description when opening HSR network device
Date: Mon, 4 Mar 2024 15:21:39 +0100 [thread overview]
Message-ID: <c984e6c2-b79a-45dc-8930-31c61e2f23c2@lunn.ch> (raw)
In-Reply-To: <8d92dcbb-828d-17f4-d199-c625505e7b0c@ti.com>
> > case HSR_PT_SLAVE_A:
> > - designation = 'A';
> > + designation = "Slave A";
>
> "designation" is now a pointer and is being assigned value
> without even allocating memory for it.
"Slave A" is in memory somewhere, probably the .rodata section. So
designation now points to that memory.
Andrew
next prev parent reply other threads:[~2024-03-04 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:32 [PATCH] net: hsr: Use full string description when opening HSR network device Lukasz Majewski
2024-03-04 10:32 ` Ravi Gunasekaran
2024-03-04 14:21 ` Andrew Lunn [this message]
2024-03-04 14:24 ` Andrew Lunn
2024-03-04 15:17 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c984e6c2-b79a-45dc-8930-31c61e2f23c2@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=m-karicheri2@ti.com \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox