From: Paolo Abeni <pabeni@redhat.com>
To: Jason Xing <kerneljasonxing@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
dsahern@kernel.org, kuniyu@amazon.com
Cc: netdev@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path
Date: Thu, 15 Feb 2024 11:12:32 +0100 [thread overview]
Message-ID: <c987d2c79e4a4655166eb8eafef473384edb37fb.camel@redhat.com> (raw)
In-Reply-To: <20240215012027.11467-1-kerneljasonxing@gmail.com>
Hi,
On Thu, 2024-02-15 at 09:20 +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> When I was debugging the reason about why the skb should be dropped in
> syn cookie mode, I found out that this NOT_SPECIFIED reason is too
> general. Thus I decided to refine it.
>
> v5:
> Link: https://lore.kernel.org/netdev/20240213134205.8705-1-kerneljasonxing@gmail.com/
> Link: https://lore.kernel.org/netdev/20240213140508.10878-1-kerneljasonxing@gmail.com/
> 1. Use SKB_DROP_REASON_IP_OUTNOROUTES instead of introducing a new
> one (Eric, David)
> 2. Reuse SKB_DROP_REASON_NOMEM to handle failure of request socket
> allocation (Eric)
> 3. Reuse NO_SOCKET instead of introducing COOKIE_NOCHILD
> 4. avoid duplication of these opt_skb tests/actions (Eric)
> 5. Use new name (TCP_ABORT_ON_DATA) for readability (David)
> 6. Reuse IP_OUTNOROUTES instead of INVALID_DST (Eric)
It looks like this is causing a lot of self-test failures:
https://netdev.bots.linux.dev/contest.html?pw-n=0&branch=net-next-2024-02-15--06-00&pass=0&skip=0
due to tcp connect timeout, e.g.:
https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/466281/9-tcp-fastopen-backup-key-sh/stdout
please have look.
Thanks!
Paolo
next prev parent reply other threads:[~2024-02-15 10:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 1:20 [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 01/11] tcp: add a dropreason definitions and prepare for cookie check Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 02/11] tcp: directly drop skb in cookie check for ipv4 Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 03/11] tcp: use drop reasons " Jason Xing
2024-02-15 21:09 ` Kuniyuki Iwashima
2024-02-16 1:28 ` Jason Xing
2024-02-16 3:03 ` Kuniyuki Iwashima
2024-02-16 3:50 ` Jason Xing
2024-02-16 4:11 ` Kuniyuki Iwashima
2024-02-16 4:41 ` Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 04/11] tcp: directly drop skb in cookie check for ipv6 Jason Xing
2024-02-15 11:08 ` Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 05/11] tcp: use drop reasons " Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 06/11] tcp: introduce dropreasons in receive path Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 07/11] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 08/11] tcp: add dropreasons in tcp_rcv_state_process() Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 09/11] tcp: make the dropreason really work when calling tcp_rcv_state_process() Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 10/11] tcp: make dropreason in tcp_child_process() work Jason Xing
2024-02-15 1:20 ` [PATCH net-next v5 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv Jason Xing
2024-02-15 10:12 ` Paolo Abeni [this message]
2024-02-15 11:10 ` [PATCH net-next v5 00/11] introduce drop reasons for tcp receive path Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c987d2c79e4a4655166eb8eafef473384edb37fb.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).