From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8D7CCA47B for ; Tue, 5 Jul 2022 12:02:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233207AbiGEMCL (ORCPT ); Tue, 5 Jul 2022 08:02:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbiGEMBY (ORCPT ); Tue, 5 Jul 2022 08:01:24 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94FDA1834F; Tue, 5 Jul 2022 05:01:22 -0700 (PDT) Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1o8hEp-000Eyk-No; Tue, 05 Jul 2022 14:01:07 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8hEp-000Uzq-CA; Tue, 05 Jul 2022 14:01:07 +0200 Subject: Re: [PATCH] MAINTAINERS: adjust XDP SOCKETS after file movement To: Maciej Fijalkowski , Magnus Karlsson Cc: Lukas Bulwahn , Andrii Nakryiko , Alexei Starovoitov , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Network Development , bpf , kernel-janitors@vger.kernel.org, open list References: <20220701042810.26362-1-lukas.bulwahn@gmail.com> From: Daniel Borkmann Message-ID: Date: Tue, 5 Jul 2022 14:01:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.6/26594/Tue Jul 5 09:24:14 2022) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/1/22 3:52 PM, Maciej Fijalkowski wrote: > On Fri, Jul 01, 2022 at 03:13:36PM +0200, Magnus Karlsson wrote: >> On Fri, Jul 1, 2022 at 2:38 PM Maciej Fijalkowski >> wrote: >>> >>> On Fri, Jul 01, 2022 at 06:28:10AM +0200, Lukas Bulwahn wrote: >>>> Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves >>>> files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust >>>> the XDP SOCKETS (AF_XDP) section in MAINTAINERS. >>>> >>>> Adjust the file entry after this file movement. >>>> >>>> Signed-off-by: Lukas Bulwahn >>>> --- >>>> Andrii, please ack. >>>> >>>> Alexei, please pick this minor non-urgent clean-up on top of the commit above. >>>> >>>> MAINTAINERS | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index fa4bfa3d10bf..27d9e65b9a85 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -22042,7 +22042,7 @@ F: include/uapi/linux/xdp_diag.h >>>> F: include/net/netns/xdp.h >>>> F: net/xdp/ >>>> F: samples/bpf/xdpsock* >>>> -F: tools/lib/bpf/xsk* >>>> +F: tools/testing/selftests/bpf/xsk* >>> >>> Magnus, this doesn't cover xdpxceiver. >>> How about we move the lib part and xdpxceiver part to a dedicated >>> directory? Or would it be too nested from main dir POV? >> >> Or we can just call everything we add xsk* something? > > No strong feelings. test_xsk.sh probably also needs to be addressed. > That's why I proposed dedicated dir. Could one of you follow-up on this for bpf-next tree? Maybe for selftests something similar as in case of the XDP entry could work. Thanks, Daniel