From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1A79366042 for ; Thu, 3 Sep 2026 08:27:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788424040; cv=none; b=C0cOpPifeXShsLFXDT6jn+AIeopEjLWGOHjvZkYhwMHxhcR/UEDdtz3lBhZBaLPF3E5ivpQTuzCpkfDhHCN2IPKroY53fIKo7gZxwLT+K7W2pmLS38wvNvebecLDbRtIN/XWWm97Cn4yXwYIRYsOZxp6/hcSsARDrQc3RzdXGs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788424040; c=relaxed/simple; bh=QHcbKX4vQy3vRwUBSr3fQ/6HMsYcVpJ+fH8mUI/pgj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=obcpUuYHAAKI9i13iqFWqOj6asIUaMGJejrZ69rQa0fZgq/NrBTBeXaiaWLYu8ztitcAPP2qvooZ54o2fVZeHztdblF/+Fst7SSLHbjEAnlUbezoh2lMOHFcEX8Mamr9ZGpxrxKeTZk/Ho7DbUVQWWpvha9zunRwfFt3beNw1Gc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EuXnDGAd; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EuXnDGAd" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-c169ae1cb26so134167466b.1 for ; Thu, 03 Sep 2026 01:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788424037; x=1789028837; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UBM23VaC7NRoTSibSXqitvOOFeGtS5Tiv5Blws+1ceU=; b=EuXnDGAdCQQIhFPc46E7iheOMgsGWg8MuISdJOXBEuzNtxw659SD16xWebgaUdldHO DwPpWvNimj32UYS3IDRpCs2Tt6EXVr4yTzmMr30tNsff62Q6d6UuwIRO9uW8HgHczQs+ 1OOCBnuMP0BonoNUAmezfRyG/wvDhNsIoXNT86Ycs1btTe5iIBmeLlXpoKAUoH6o6sM/ yR2MB/lQl8Y67RIFVQCxcmquCR+wkP/aiU3xsebq0EleCyN3gHFTOR91TPU/DtlsCQzr bmYWE/ldzCQewER0wTTONxW/Eqa0tNMnifUssxGGUU9u2iCSr/DTQMsbcSOI+CTfZ9mu AjAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788424037; x=1789028837; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UBM23VaC7NRoTSibSXqitvOOFeGtS5Tiv5Blws+1ceU=; b=m8Vlx8zVhVLzwcIt5JH6mSMkXPZzSVYb3gI5k1TosXR8JN6/zVvNu5cF5BefidD3Jt Fp2K+HqsOqPefsSGN/StJTakHQGLPeJOWaWfdXCtZvrJ46rBBfgBoOsX6ytsZm37X7Py 8gl1HgJaolUN+cOlQRXp0op+IbvBwwVb3r4VELzSsxq2PB1TMMX2tfOiSY4JiHDo0Qjm DJ3fHN81Z5UT8CRRBUh5bJqwFOIgHIuFER2KRJHUdrnkP2xG9K+f00taSOCHZM+GS/3N rpO4k9LmeLfh1YnTrkTBMWhZxpk1pbwA+w0aFwyfv9czmV6JiZovUv4lahKODbY3L0xd +QtA== X-Forwarded-Encrypted: i=1; AKwUvBxgdV2BJa/3HQxnqHbJTaBxDNUe7zKYbUa2HwWL9qexTiDKcmi/39rBKlisM2jgRZzTiFD8RSw=@vger.kernel.org X-Gm-Message-State: AFuF++lnOkFMx3/UkCcUbkIGhPnCE85zFbaoOqOrUdzyreqwN4QhI/4d bDFqWC0DLHRZz1WxHAaz9XGwUCpdhd1P28Lq0/vDUX2ANOTQth9N40cU X-Gm-Gg: AYBFou3UhrI9aZGGj+Rs/kT5x8wuhPifCHRBLzeMWFgNBJHx7aalTo8RhYSIFmS7XDE jWVeHp9z8fmx3sFwwccRlvqma29gdOGEWcgTpStCwqXTFsbvRNmMvbALai3ESoAYOSPMsDIAleV +JMloJpS3p51KtBLjnZ8IvM5bRBxRYn3f1Fygi372gP1xrQKxUTAq2TJtVv0tTXmeUjTaQBpvyr reHHy1R4a9abm4yVklzltWOuejHwDSgv9PMJ7PnDUwa+wt208HvXuo1Wpo/v2n6dJXO8+xS8Em1 pCanW1iw4uN3SEJFT6fWV/Dq503dYhWGxJ21aNYOgpmfYgJ7+SGpFk86pT6IJ0rG5jAlpzQQhz+ pHkVwAcno0C+qkDawq8mqm9RVl59h1vj+GBTI0A6jDtpXrNBH3KTxCKUDbGgkEvPhq7Pt845arc rb96oByXVPk/qjvGbHDx4NVAKv/KjMD4zb/E5gIws7lfMQYQTI2i5/macdvuA6LcF9NYGePtsiM loovO+/Ydgs X-Received: by 2002:a17:907:3f23:b0:c25:5a26:3787 with SMTP id a640c23a62f3a-c25f011fb33mr251661166b.8.1788424036654; Thu, 03 Sep 2026 01:27:16 -0700 (PDT) Received: from [192.168.1.124] (78-2-9-45.adsl.net.t-com.hr. [78.2.9.45]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a67f952c1bsm2043758a12.26.2026.09.03.01.27.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 01:27:16 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 10:27:15 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3] net: wwan: qcom_bam_dmux: account network packets To: Stephan Gerhold Cc: Stephan Gerhold , Loic Poulain , Sergey Ryazanov , Johannes Berg , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260902124506.363174-1-sinyavin@gmail.com> Content-Language: en-US From: Dmitry Sinyavin In-Reply-To: <20260902124506.363174-1-sinyavin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The delayed Sashiko review of v2 identified a valid teardown race that also affects v3. I will address it in v4. pw-bot: changes-requested 02.09.2026 14:45, Dmitry Sinyavin wrote: > The BAM-DMUX data path does not update the network device packet and byte > counters. As a result, userspace sees zero traffic even while packets are > being transferred. > > Use the standard per-CPU software statistics helpers. Account transmitted > packets after their DMA completion and received packets after removing the > BAM-DMUX header and padding. > > Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver") > Signed-off-by: Dmitry Sinyavin > Reviewed-by: Loic Poulain > --- > v3: > - Count packets discarded by the transmit error path. > > v2: > - Read the TX payload length after unmapping the DMA buffer and combine the > network-device checks. > > v2: https://lore.kernel.org/netdev/20260831181006.1382372-1-sinyavin@gmail.com/ > v1: https://lore.kernel.org/netdev/20260830085400.2542956-1-sinyavin@gmail.com/ > > Build-tested for ARM with Clang and W=1 using allmodconfig and allyesconfig. > Hardware-tested on an MDM9607-based device: three 32-byte ICMP probes completed > without loss, and the RX and TX counters each advanced by three packets and > 180 bytes. > > drivers/net/wwan/qcom_bam_dmux.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/wwan/qcom_bam_dmux.c b/drivers/net/wwan/qcom_bam_dmux.c > index cc6ace8d6437..ef3356200b3e 100644 > --- a/drivers/net/wwan/qcom_bam_dmux.c > +++ b/drivers/net/wwan/qcom_bam_dmux.c > @@ -177,8 +177,12 @@ static void bam_dmux_tx_callback(void *data) > { > struct bam_dmux_skb_dma *skb_dma = data; > struct sk_buff *skb = skb_dma->skb; > + struct net_device *netdev = skb->dev; > > bam_dmux_tx_done(skb_dma); > + if (netdev) > + dev_sw_netstats_tx_add(netdev, 1, > + ((struct bam_dmux_hdr *)skb->data)->len); > dev_consume_skb_any(skb); > } > > @@ -368,6 +372,7 @@ static netdev_tx_t bam_dmux_netdev_start_xmit(struct sk_buff *skb, > > drop: > bam_dmux_tx_done(skb_dma); > + dev_core_stats_tx_dropped_inc(netdev); > dev_kfree_skb_any(skb); > return NETDEV_TX_OK; > } > @@ -402,6 +407,7 @@ static const struct net_device_ops bam_dmux_ops = { > .ndo_open = bam_dmux_netdev_open, > .ndo_stop = bam_dmux_netdev_stop, > .ndo_start_xmit = bam_dmux_netdev_start_xmit, > + .ndo_get_stats64 = dev_get_tstats64, > }; > > static const struct device_type wwan_type = { > @@ -421,6 +427,7 @@ static void bam_dmux_netdev_setup(struct net_device *dev) > dev->needed_headroom = sizeof(struct bam_dmux_hdr); > dev->needed_tailroom = sizeof(u32); /* word-aligned */ > dev->tx_queue_len = DEFAULT_TX_QUEUE_LEN; > + dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS; > > /* This perm addr will be used as interface identifier by IPv6 */ > dev->addr_assign_type = NET_ADDR_RANDOM; > @@ -533,6 +540,7 @@ static void bam_dmux_cmd_data(struct bam_dmux_skb_dma *skb_dma) > break; > } > > + dev_sw_netstats_rx_add(netdev, skb->len); > netif_receive_skb(skb); > } > > > base-commit: 2188569e7e1b0bc3f3b557dc97ab7a02befc11c8