From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D133191C4 for ; Tue, 23 Sep 2025 09:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758620292; cv=none; b=YJOOQku9phkZQSR7Cto9+jTDNeliXowTAqlnZiKcPBj+JSxKO9+dsUcO/SEwRXVITfkOwvU8s1zT/jupwONXcDO53rAsGXStQwJ41oCXpF5Dxn+t60XXBvn5KaDJ3vSdqtyhW2udjSQAJ9kZCwjdzYHQrGmCA565XeBGzcrguFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758620292; c=relaxed/simple; bh=ibQFUfWgjlrRh6K0i5rnkYWrfmjyVOaaxdim7ktNBj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LSiNwVukSGZFyJWttzOlrAKeoN8KwcmR8ZaPRsA09WuBw08bVr4a9r4O4CqoO/0tnMR6ASyLH4qtgo1m9rZ4Dybn6gIYf55XxYJAliPVrZi6OAytR/J99zjGv+1bC4fKwWyScGGGN0QyYH73+waWX1w90mqieQ5aghlDL6dW1ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=cZcOBnsa; arc=none smtp.client-ip=44.202.169.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="cZcOBnsa" Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id 0xwQvXBeQKXDJ0zTHvAvwC; Tue, 23 Sep 2025 09:38:03 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id 0zTFv2WL2fjrX0zTGvC2gc; Tue, 23 Sep 2025 09:38:02 +0000 X-Authority-Analysis: v=2.4 cv=ItcecK/g c=1 sm=1 tr=0 ts=68d26a7a a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=YFVba0b8p+FN4MzmaWosng==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=7T7KSl7uo7wA:10 a=8Vd6GBVApGGO7YSmZGYA:9 a=QEXdDO2ut3YA:10 a=xYX6OU9JNrHFPr8prv8u:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZY1494lZCKLAGhYiwMqyD720As0K42qBB8WHh+Ldudk=; b=cZcOBnsa1Ssm9jkMVx+Vf6ZVBb DA8xlpCFryl594CBOIOju0oLqGKOBzBpx0cQ9B0Xz1oXRME7A4p8zYNYhX889Rra5rDMwKPrazyQq ItCZtRbV7nX4ICn2Dy66jhJn49ht4FePiJ39eU7BVxVn3hfSAAiYT1LcRJUS0qpiWP+Ox7+vGy+qK 6GoHa+Zz/ovS+rdzzTf9wLil0Sw11jBHZf6nYd7Xz4M2W+q2HgM9MJxtpHkfYF+9bKk+7DLrPWTsD N2L7y4jqQ7HtvGF7pqibxfmkjii+lPTsgvA4ef9wDVcxx4K02fwOFQmNufShHBusxyXTSRs4kDZrq 76nqKYRw==; Received: from [83.214.156.71] (port=40424 helo=[192.168.1.104]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.1) (envelope-from ) id 1v0zTE-00000000QEZ-3hjY; Tue, 23 Sep 2025 04:38:01 -0500 Message-ID: Date: Tue, 23 Sep 2025 11:37:55 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] tls: Avoid -Wflex-array-member-not-at-end warning To: Sabrina Dubroca , "Gustavo A. R. Silva" Cc: John Fastabend , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 83.214.156.71 X-Source-L: No X-Exim-ID: 1v0zTE-00000000QEZ-3hjY X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.104]) [83.214.156.71]:40424 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEngmJFhYPhDQ923AATVCERHj9n8oT6P+tsN5Wav9KSO3K6MRJlvSxcUM1oRXk223+9LyTgNxFkGWbXlAhBFZ2NiHjo3s1B6jlNDNK6LVsmkCgS5ffD6 Yj7GDRlKfYeUfzyZ+mRDObTGXm6qwl/zc14ZrFOz/h1BOupnU9Qz1fRR2q0BWqIa+Z7DXTMNRm2Hp6UEERjLlu9w1eFzTncwvyA= On 9/22/25 17:21, Sabrina Dubroca wrote: > 2025-09-22, 16:39:20 +0200, Gustavo A. R. Silva wrote: >> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are >> getting ready to enable it, globally. >> >> Use the new TRAILING_OVERLAP() helper to fix the following warning: >> >> net/tls/tls.h:131:29: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] >> >> This helper creates a union between a flexible-array member (FAM) >> and a set of members that would otherwise follow it. This overlays >> the trailing members onto the FAM while preserving the original >> memory layout. > > Do we need to keep aead_req_ctx in tls_rec? It doesn't seem to be > used, and I don't see it ever being used since it was introduced in > commit a42055e8d2c3 ("net/tls: Add support for async encryption of > records for performance"). If this (flex array) is not going to be needed in the future, I'm happy to remove it. :) Thanks -Gustavo