From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <ast@kernel.org>, <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<hawk@kernel.org>, <amritha.nambiar@intel.com>,
<j.vosburgh@gmail.com>, <andy@greyhouse.net>,
<shayagr@amazon.com>, <akiyano@amazon.com>,
<ioana.ciornei@nxp.com>, <claudiu.manoil@nxp.com>,
<vladimir.oltean@nxp.com>, <wei.fang@nxp.com>,
<shenwei.wang@nxp.com>, <xiaoning.wang@nxp.com>,
<linux-imx@nxp.com>, <dmichail@fungible.com>,
<jeroendb@google.com>, <pkaligineedi@google.com>,
<shailend@google.com>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <horatiu.vultur@microchip.com>,
<UNGLinuxDriver@microchip.com>, <kys@microsoft.com>,
<haiyangz@microsoft.com>, <wei.liu@kernel.org>,
<decui@microsoft.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
<mcoquelin.stm32@gmail.com>, <grygorii.strashko@ti.com>,
<longli@microsoft.com>, <sharmaajay@microsoft.com>,
<daniel@iogearbox.net>, <john.fastabend@gmail.com>,
<gerhard@engleder-embedded.com>, <simon.horman@corigine.com>,
<leon@kernel.org>, <linux-hyperv@vger.kernel.org>
Subject: Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers
Date: Wed, 2 Aug 2023 18:00:20 +0200 [thread overview]
Message-ID: <c9df397a-41c4-02f6-c3b1-1a7c2cf4ad6d@intel.com> (raw)
In-Reply-To: <20230802003246.2153774-2-kuba@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 1 Aug 2023 17:32:44 -0700
> Handful of drivers currently expect to get xdp.h by virtue
> of including netdevice.h. This will soon no longer be the case
> so add explicit includes.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: j.vosburgh@gmail.com
> CC: andy@greyhouse.net
> CC: shayagr@amazon.com
> CC: akiyano@amazon.com
> CC: ioana.ciornei@nxp.com
> CC: claudiu.manoil@nxp.com
> CC: vladimir.oltean@nxp.com
> CC: wei.fang@nxp.com
> CC: shenwei.wang@nxp.com
> CC: xiaoning.wang@nxp.com
> CC: linux-imx@nxp.com
> CC: dmichail@fungible.com
> CC: jeroendb@google.com
> CC: pkaligineedi@google.com
> CC: shailend@google.com
> CC: jesse.brandeburg@intel.com
> CC: anthony.l.nguyen@intel.com
> CC: horatiu.vultur@microchip.com
> CC: UNGLinuxDriver@microchip.com
> CC: kys@microsoft.com
> CC: haiyangz@microsoft.com
> CC: wei.liu@kernel.org
> CC: decui@microsoft.com
> CC: peppe.cavallaro@st.com
> CC: alexandre.torgue@foss.st.com
> CC: joabreu@synopsys.com
> CC: mcoquelin.stm32@gmail.com
> CC: grygorii.strashko@ti.com
> CC: longli@microsoft.com
> CC: sharmaajay@microsoft.com
> CC: daniel@iogearbox.net
> CC: hawk@kernel.org
> CC: john.fastabend@gmail.com
> CC: gerhard@engleder-embedded.com
> CC: simon.horman@corigine.com
> CC: leon@kernel.org
> CC: linux-hyperv@vger.kernel.org
> CC: bpf@vger.kernel.org
> ---
> drivers/net/bonding/bond_main.c | 1 +
> drivers/net/ethernet/amazon/ena/ena_netdev.h | 1 +
> drivers/net/ethernet/engleder/tsnep.h | 1 +
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 +
> drivers/net/ethernet/freescale/enetc/enetc.h | 1 +
> drivers/net/ethernet/freescale/fec.h | 1 +
> drivers/net/ethernet/fungible/funeth/funeth_txrx.h | 1 +
> drivers/net/ethernet/google/gve/gve.h | 1 +
> drivers/net/ethernet/intel/igc/igc.h | 1 +
> drivers/net/ethernet/microchip/lan966x/lan966x_main.h | 1 +
> drivers/net/ethernet/microsoft/mana/mana_en.c | 1 +
> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 +
> drivers/net/ethernet/ti/cpsw_priv.h | 1 +
> drivers/net/hyperv/hyperv_net.h | 1 +
> drivers/net/tap.c | 1 +
> include/net/mana/mana.h | 2 ++
> 16 files changed, 17 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 7a0f25301f7e..2f21cca4fdaf 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -90,6 +90,7 @@
> #include <net/tls.h>
> #endif
> #include <net/ip6_route.h>
> +#include <net/xdp.h>
>
> #include "bonding_priv.h"
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h
> index 248b715b4d68..a1134152ecce 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
> @@ -15,6 +15,7 @@
> #include <linux/netdevice.h>
> #include <linux/skbuff.h>
> #include <uapi/linux/bpf.h>
> +#include <net/xdp.h>
Alphabetical sorting? :>
(for the entire patch)
>
> #include "ena_com.h"
> #include "ena_eth_com.h"
[...]
Thanks,
Olek
next prev parent reply other threads:[~2023-08-02 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 0:32 [PATCH bpf-next 0/3] net: struct netdev_rx_queue and xdp.h reshuffling Jakub Kicinski
2023-08-02 0:32 ` [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers Jakub Kicinski
2023-08-02 2:26 ` Wei Fang
2023-08-02 16:00 ` Alexander Lobakin [this message]
2023-08-02 18:06 ` Gerhard Engleder
2023-08-02 0:32 ` [PATCH bpf-next 2/3] net: move struct netdev_rx_queue out of netdevice.h Jakub Kicinski
2023-08-02 19:42 ` Nambiar, Amritha
2023-08-02 0:32 ` [PATCH bpf-next 3/3] net: invert the netdevice.h vs xdp.h dependency Jakub Kicinski
2023-08-02 2:31 ` [PATCH bpf-next 0/3] net: struct netdev_rx_queue and xdp.h reshuffling Alexei Starovoitov
2023-08-02 3:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9df397a-41c4-02f6-c3b1-1a7c2cf4ad6d@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=akiyano@amazon.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amritha.nambiar@intel.com \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@iogearbox.net \
--cc=decui@microsoft.com \
--cc=dmichail@fungible.com \
--cc=gerhard@engleder-embedded.com \
--cc=grygorii.strashko@ti.com \
--cc=haiyangz@microsoft.com \
--cc=hawk@kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=ioana.ciornei@nxp.com \
--cc=j.vosburgh@gmail.com \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=longli@microsoft.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=sharmaajay@microsoft.com \
--cc=shayagr@amazon.com \
--cc=shenwei.wang@nxp.com \
--cc=simon.horman@corigine.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=wei.liu@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).