From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065D5C43215 for ; Thu, 21 Nov 2019 15:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D302A206CC for ; Thu, 21 Nov 2019 15:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V9JvsFLW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfKUP4k (ORCPT ); Thu, 21 Nov 2019 10:56:40 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:43075 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726541AbfKUP4j (ORCPT ); Thu, 21 Nov 2019 10:56:39 -0500 Received: by mail-qv1-f68.google.com with SMTP id cg2so1590337qvb.10 for ; Thu, 21 Nov 2019 07:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uo29jvd3MvEnaXPNSX8k39P3wPPu4OCIWaGTEkLO67Y=; b=V9JvsFLWwMItV1uYU9jSM3EdBB9baMm3tce6P/HR77UwWM6RoIVv4i+yuUoDninY1C cZ2dssTJ1w6XsZ+b+wAM+vhEZAaMIxreTQdypyPYFkaYcGrgRAoDAZCbV9ipvYfICZQF yrdCHuS4C4ktZCijGNZqvSoNiiYtg3/OVExWr+t9GrbZZm8n6TB0U4cg/d+iCQHPQDqP rVfIgM4UM0R/YNCnNeRiAMRqJ1xItMpz4sYLB9MmFGDTL0k3+uhtlW2ovJHAWGMo6u1R o1Y2NRyn2juVkufZvvybJXPi8VKiHTkWyae8bsq/HccTJSacpxSN8EFWZkvbmgvp1buq bGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uo29jvd3MvEnaXPNSX8k39P3wPPu4OCIWaGTEkLO67Y=; b=JY2vOqo/jqvEDeKqs1kBe6+mnuOEtioEiqTTnIhN86ok2Xwz2QmmFRHzevtvFMnt5u iHVRS09ihFAzAF9eN2lFYuYn06riHIk8zaCXIrgijbCrudKqgILB6jMgyxQ3ggcCTxat lZuza2ZitwKTsJFHO2mCvRn0FgRnoLzkKKgOuIoiwbb+KYFwKrpfGV3M6IfwpLQQqc/u ZAwfx3M0NGRV54fF/vC7U40QbUu8PIMHRdubm4Wj5WvBC3/AQzAC0KIW3ZcAuE4j3pQq 3GtmWXSSR4waFXByDAq/cnT93mY+83Q33jfhJkSDi2UpPj6dEY2cwqXZnU5kuzm4KVBF ltcQ== X-Gm-Message-State: APjAAAV4cQCqriwX6kCWmwj0WWw0n/s7OqyAud5dhe30IWpqq660fFt8 SQITXeNvjzooycvy96aXpl0= X-Google-Smtp-Source: APXvYqw4ISnccH01RU50VXX+dhjxcxSzgKWdZ4ugHhjSqKbt+Vvdr1EVv+TDC/sAl2ItO6IVaW6g0g== X-Received: by 2002:a0c:d983:: with SMTP id y3mr9060562qvj.52.1574351798142; Thu, 21 Nov 2019 07:56:38 -0800 (PST) Received: from dahern-DO-MB.local ([2601:282:800:fd80:b9b1:601f:b338:feda]) by smtp.googlemail.com with ESMTPSA id r80sm1555568qke.121.2019.11.21.07.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:56:37 -0800 (PST) Subject: Re: [PATCH net-next 1/4] net: sched: add vxlan option support to act_tunnel_key To: Xin Long , Jakub Kicinski Cc: network dev , davem , Simon Horman References: <20191119161241.5b010232@cakuba.netronome.com> <20191120091704.2d10ab90@cakuba.netronome.com> From: David Ahern Message-ID: Date: Thu, 21 Nov 2019 08:56:36 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/20/19 10:45 PM, Xin Long wrote: >> Hm, that's what I thought but then we were asked to add it in >> act_mpls.c. I should've checked the code. >> >> Anyway, we should probably clean up act_mpls.c and act_ct.c so people >> don't copy it unnecessarily. > will send a cleanup, also for the one in net/ipv4/nexthop.c. thanks. Clearly, I forgot .strict_type_start does not apply to users of the new API.