From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002D5ECAAA1 for ; Tue, 30 Aug 2022 14:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbiH3OTX (ORCPT ); Tue, 30 Aug 2022 10:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiH3OTW (ORCPT ); Tue, 30 Aug 2022 10:19:22 -0400 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37782FE044; Tue, 30 Aug 2022 07:19:20 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 4D99A18845C6; Tue, 30 Aug 2022 14:19:17 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 4575825032B7; Tue, 30 Aug 2022 14:19:17 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 320A69EC0003; Tue, 30 Aug 2022 14:19:17 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Tue, 30 Aug 2022 16:19:16 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: Nikolay Aleksandrov , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 1/6] net: bridge: add locked entry fdb flag to extend locked port feature In-Reply-To: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-2-netdev@kapio-technology.com> <972663825881d135d19f9e391b2b7587@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022-08-29 18:12, Ido Schimmel wrote: > On Mon, Aug 29, 2022 at 04:02:46PM +0200, netdev@kapio-technology.com > wrote: >> On 2022-08-27 13:30, Nikolay Aleksandrov wrote: >> > On 26/08/2022 14:45, Hans Schultz wrote: >> > >> > Hi, >> > Please add the blackhole flag in a separate patch. >> > A few more comments and questions below.. >> > >> >> Hi, >> if userspace is to set this flag I think I need to change stuff in >> rtnetlink.c, as I will need to extent struct ndmsg with a new u32 >> entry as >> the old u8 flags is full. > > You cannot extend 'struct ndmsg'. That's why 'NDA_FLAGS_EXT' was > introduced. See: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2c611ad97a82b51221bb0920cc6cac0b1d4c0e52 > > 'NTF_EXT_BLACKHOLE' belongs in 'NDA_FLAGS_EXT' like you have it now, > but > the kernel should not reject it in br_fdb_add(). > >> Maybe this is straight forward, but I am not so sure as I don't know >> that >> code too well. Maybe someone can give me a hint...? The question I have is if I can use nlh_flags to send the extended flags further on to fdb_add_entry(), where I expect to need it? (the extended flags are u32, while nlh_flags are u16)