From: David Ahern <dsahern@gmail.com>
To: Hoang Le <hoang.h.le@dektech.com.au>,
dsahern@gmail.com, jon.maloy@ericsson.com, maloy@donjonn.com,
ying.xue@windriver.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [iproute2-next v6] tipc: support interface name when activating UDP bearer
Date: Fri, 28 Jun 2019 17:03:36 -0600 [thread overview]
Message-ID: <c9f82d53-9908-088d-7d42-a2acb01655b8@gmail.com> (raw)
In-Reply-To: <20190625043439.6691-1-hoang.h.le@dektech.com.au>
On 6/24/19 10:34 PM, Hoang Le wrote:
> Support for indicating interface name has an ip address in parallel
> with specifying ip address when activating UDP bearer.
> This liberates the user from keeping track of the current ip address
> for each device.
>
> Old command syntax:
> $tipc bearer enable media udp name NAME localip IP
>
> New command syntax:
> $tipc bearer enable media udp name NAME [localip IP|dev DEVICE]
>
> v2:
> - Removed initial value for fd
> - Fixed the returning value for cmd_bearer_validate_and_get_addr
> to make its consistent with using: zero or non-zero
> v3: - Switch to use helper 'get_ifname' to retrieve interface name
> v4: - Replace legacy SIOCGIFADDR by netlink
> v5: - Fix leaky rtnl_handle
>
> Acked-by: Ying Xue <ying.xue@windriver.com>
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
> ---
> tipc/bearer.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 89 insertions(+), 5 deletions(-)
>
applied to iproute2-next. Thanks
prev parent reply other threads:[~2019-06-28 23:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 4:34 [iproute2-next v6] tipc: support interface name when activating UDP bearer Hoang Le
2019-06-28 23:03 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f82d53-9908-088d-7d42-a2acb01655b8@gmail.com \
--to=dsahern@gmail.com \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox