From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 0/2] leds: drop led_trigger_rename_static() Date: Fri, 15 Jun 2018 22:49:48 +0200 Message-ID: References: <20180518085333.26187-1-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: linux-leds@vger.kernel.org, linux-can@vger.kernel.org, kernel@pengutronix.de To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Pavel Machek , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , netdev@vger.kernel.org Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:54584 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753735AbeFOUtw (ORCPT ); Fri, 15 Jun 2018 16:49:52 -0400 In-Reply-To: <20180518085333.26187-1-u.kleine-koenig@pengutronix.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi, I need can or net maintainer's ack for merging this set via LED tree. It's been awaiting feedback for a few weeks now and it is blocking another set depending on it. On 05/18/2018 10:53 AM, Uwe Kleine-König wrote: > Hello, > > initially I prepared a patch to fix the broken things in > led_trigger_rename_static(), but given that there is only the > can-trigger driver that makes use of this function and the netdev > trigger implements a super set of the can-trigger, removing both the > can-trigger and the broken function seems sensible. > > Best regards > Uwe > > Uwe Kleine-König (2): > can: drop led trigger support > leds: remove unused function led_trigger_rename_static() > > drivers/leds/led-triggers.c | 13 --- > drivers/net/can/Kconfig | 11 -- > drivers/net/can/Makefile | 2 - > drivers/net/can/at91_can.c | 10 -- > drivers/net/can/c_can/c_can.c | 11 -- > drivers/net/can/dev.c | 5 - > drivers/net/can/flexcan.c | 8 -- > drivers/net/can/ifi_canfd/ifi_canfd.c | 9 -- > drivers/net/can/led.c | 143 -------------------------- > drivers/net/can/m_can/m_can.c | 9 -- > drivers/net/can/rcar/rcar_can.c | 8 -- > drivers/net/can/rcar/rcar_canfd.c | 7 -- > drivers/net/can/rx-offload.c | 2 - > drivers/net/can/sja1000/sja1000.c | 15 +-- > drivers/net/can/spi/hi311x.c | 8 -- > drivers/net/can/spi/mcp251x.c | 10 -- > drivers/net/can/sun4i_can.c | 7 -- > drivers/net/can/ti_hecc.c | 9 -- > drivers/net/can/usb/mcba_usb.c | 7 -- > drivers/net/can/usb/usb_8dev.c | 11 -- > drivers/net/can/xilinx_can.c | 9 -- > include/linux/can/dev.h | 10 -- > include/linux/can/led.h | 54 ---------- > include/linux/leds.h | 18 ---- > 24 files changed, 1 insertion(+), 395 deletions(-) > delete mode 100644 drivers/net/can/led.c > delete mode 100644 include/linux/can/led.h > -- Best regards, Jacek Anaszewski