From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com,
mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next] vxlan: Use a per-namespace nexthop listener instead of a global one
Date: Mon, 2 Nov 2020 18:45:10 -0700 [thread overview]
Message-ID: <ca51f883-736e-f862-a3b2-5f6f34b99d4d@gmail.com> (raw)
In-Reply-To: <20201101113926.705630-1-idosch@idosch.org>
On 11/1/20 4:39 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> The nexthop notification chain is a per-namespace chain and not a global
> one like the netdev notification chain.
>
> Therefore, a single (global) listener cannot be registered to all these
> chains simultaneously as it will result in list corruptions whenever
> listeners are registered / unregistered.
>
> Instead, register a different listener in each namespace.
>
> Currently this is not an issue because only the VXLAN driver registers a
> listener to this chain, but this is going to change with netdevsim and
> mlxsw also registering their own listeners.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> drivers/net/vxlan.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2020-11-03 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 11:39 [PATCH net-next] vxlan: Use a per-namespace nexthop listener instead of a global one Ido Schimmel
2020-11-03 1:45 ` David Ahern [this message]
2020-11-03 23:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca51f883-736e-f862-a3b2-5f6f34b99d4d@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).