From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
alexander.duyck@gmail.com, "Brandeburg,
Jesse" <jesse.brandeburg@intel.com>
Subject: Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available
Date: Tue, 19 Dec 2017 09:41:39 -0800 [thread overview]
Message-ID: <ca709329-a47a-2e76-b1fc-38fc665d7c0b@intel.com> (raw)
In-Reply-To: <20171219174259-mutt-send-email-mst@kernel.org>
On 12/19/2017 7:47 AM, Michael S. Tsirkin wrote:
> I'll need to look at this more, in particular the feature
> bit is missing here. For now one question:
>
> On Mon, Dec 18, 2017 at 04:40:36PM -0800, Sridhar Samudrala wrote:
>> @@ -56,6 +58,8 @@ module_param(napi_tx, bool, 0644);
>> */
>> DECLARE_EWMA(pkt_len, 0, 64)
>>
>> +#define VF_TAKEOVER_INT (HZ / 10)
>> +
>> #define VIRTNET_DRIVER_VERSION "1.0.0"
>>
>> static const unsigned long guest_offloads[] = {
> Why is this delay necessary? And why by 100ms?
This is based on netvsc implementation and here is the commit that
added this delay. Not sure if this needs to be 100ms.
commit 6123c66854c174e4982f98195100c1d990f9e5e6
Author: stephen hemminger <stephen@networkplumber.org>
Date: Wed Aug 9 17:46:03 2017 -0700
netvsc: delay setup of VF device
When VF device is discovered, delay bring it automatically up in
order to allow userspace to some simple changes (like renaming).
next prev parent reply other threads:[~2017-12-19 17:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 0:40 [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2017-12-19 15:47 ` Michael S. Tsirkin
2017-12-19 17:41 ` Samudrala, Sridhar [this message]
2017-12-19 17:55 ` Stephen Hemminger
2017-12-19 18:07 ` Michael S. Tsirkin
2017-12-19 18:13 ` Stephen Hemminger
2017-12-19 18:21 ` David Miller
2017-12-19 18:41 ` Stephen Hemminger
2017-12-19 19:42 ` Samudrala, Sridhar
2017-12-19 19:46 ` Stephen Hemminger
2017-12-19 22:37 ` Samudrala, Sridhar
2017-12-19 22:53 ` Stephen Hemminger
2017-12-20 0:26 ` Samudrala, Sridhar
2017-12-21 1:31 ` Siwei Liu
2017-12-21 2:16 ` Siwei Liu
2017-12-21 4:52 ` Jakub Kicinski
2017-12-22 8:42 ` Siwei Liu
2017-12-19 18:20 ` David Miller
2017-12-20 10:51 ` Vitaly Kuznetsov
2017-12-20 22:33 ` Jakub Kicinski
2017-12-21 0:15 ` Michael S. Tsirkin
2017-12-21 0:29 ` Jakub Kicinski
2017-12-21 0:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca709329-a47a-2e76-b1fc-38fc665d7c0b@intel.com \
--to=sridhar.samudrala@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).