From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38FD640B6E9 for ; Thu, 9 Jul 2026 10:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593975; cv=none; b=coadAc8oTEkFmwYlLfxjg3iIDxHznB+l1HkVxIHbkhyRFqdgoqqhN3b7332ymjp2AjF04D7CIV2w7209EKzJcf5imb5AY9IgWV9NZIObo8jN4m7n56bQYvwSHAY5MjcYAVv7M/KT2LTGKd56tR1eMhuGUWEWj1R16TWffetkINQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593975; c=relaxed/simple; bh=ALw1vDHV5L4nvGbJoc+jSU8mWvhkA4JdMp1Q/Jp5JGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nZQLBTUhlMZdBYfKoZmrQA2oBOM/qAP/gGxAqzGgW/+FxAba+vd/4M5CRPdb1AycXiR3qSVXzsbJF9/wxwPdoYw8Wqq+Yefc/WjM8zJ8TA5DWnuh1yhI7LK0U2+x4niK5EBKX4NfaJ+UMPkjqu3UFg+XW7hqBNkRv8MwQtrwOfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NPkDu97n; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ecF1zYb7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NPkDu97n"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ecF1zYb7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783593969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I49PQ9PyUdCuLERxmFaB0ytRW4SbKdB8bINg9r85uDU=; b=NPkDu97nwWj9NsH7veYbpDazTADQpgfeXF6EkKNWydRl1vR9ENNO9xj7MuJMY+CYDZU/CF 1cNhETh+hdQ6Y7hP1cUeNYqnHN8FHBh3D76qdDIv6HvlipssLYtfzxX9Jbvoc+93kIOU+q ltHF7EAsCbn0Pgoiij9GIhmWIklxltg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-Z72WNSbtNrOzengjZAchQg-1; Thu, 09 Jul 2026 06:46:08 -0400 X-MC-Unique: Z72WNSbtNrOzengjZAchQg-1 X-Mimecast-MFC-AGG-ID: Z72WNSbtNrOzengjZAchQg_1783593967 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-473f4a48e9aso455635f8f.2 for ; Thu, 09 Jul 2026 03:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783593967; x=1784198767; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=I49PQ9PyUdCuLERxmFaB0ytRW4SbKdB8bINg9r85uDU=; b=ecF1zYb7w3M4xqQYWX9RKP8KMzzL4+bUF0n5t9qxP9i1nFdFw9i4d/+QuB3HoFMjB/ 1q9lPrW5ekmrSyEequpx6aNt+Abax7MBnR7o8/34prZ64axx+t5m9r1jj1sWBTEh+Ufz 0OKqaEpnlQxR2tDTR7mfORPRXAtBz7q2qmWNbXnnDpLZmVvmUdS5Af3Wp4t1g/xVO3Cp bjhw/+Lmd2+w2F8F5aqg15aKDMUW3V2uQ9JCRCdukge7RhxEpa1oWsTWpZV534CLp4zq ngtRJCEwTbagSM1Blyaj3Pwm6ECQCqZkk0h4grsl65YFckPzKzl9BJV/TalHjrI6zPBA pnEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783593967; x=1784198767; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I49PQ9PyUdCuLERxmFaB0ytRW4SbKdB8bINg9r85uDU=; b=fH43vY4/SmU1UMBh0o8o+qIVvJ/vMKALzkPiN6dXqHLaONbAk/y6KsGxvwhERFxMzD qy7HIw8VsoOyUXhT3XCGgIAl8RV5viMopQ8fg0fCZvijS2pm0qHHSYL5XnJbNQDAD1je e4GmzUEqkHgOFsKXk8MUgXtlhovAr3b9bpgmis3iGeGC9ScXLKQCnqOHLN90p6UQyt5Y ZrAUPfOSkZXcWeyCGg5ne0ZCLj7bOxtR2qjszq6GcxgUbQzWpL/qGiuv99vQwlWGSeL1 ZHt8pQrjI/q9zsi8Fi3IGjf7j9c3Dh1lbGyOIYMVpt+DOULXf8Z3FKczV3mVDOJ3plpi BPaw== X-Forwarded-Encrypted: i=1; AHgh+RoJ8U1LEbgJQWgMRaJVGMV3CAiYKFq8ttilC1iMAk1OxY82238XGiKRb4WgkE2Epp2KACVWEmY=@vger.kernel.org X-Gm-Message-State: AOJu0YwMiFYJHs4epODqJSlxttNhMu6bczIForkSVwPvtBCe1+yo+9DD 21LdouWvhu/TkiuKV1KNa7YhBbj6idRy+mXKZMkCC8a7oSl7fkzOj6mwiHNMAZcP2EGddKuMLct xs9Mz76IH7yk8QPfg/gruDAXFDBYsqx7pboy1ThLJiTu3IMDs1W+ZtRLhJA== X-Gm-Gg: AfdE7clAgCfD/rBhFiVl6fe6oqvcRygNxMAa4eCbMcOaBQcxWrtqUPfuNUuoHTUTnc8 YOxvAWoWjf5p0nl30HRU4FpfEFIgkgLw2HJdu5t1Li8ugUBh7Ru8CrlH+E8KmrlAQ2W/sNgzgoD ACSiMQJNadYl6rU77qAP9H4Q2q6co8vETFbK8ojd2sxrGbbWgCb1qpSLvJ9qd/kINFER7KpMvWr z7vFONLplsQItN1p8pCAPOyJicgY9LRwiAq2phvJDgk4zBJrp5Qx+cNVeoBauBMOsCXkhRkhJ+l JqlHYlDBx5ZM7m4VkTwX9uFhd+4aH0ZMP6wDLwJGr6y5w3nQOG+xPrEzgehqnuiA/YXtPrUgHkH CTQ6uIKbfSmwHBskgrdOvt2tWSCXb63iU4NL5ug018LFJytXgHFd6LtRDFGDRkRvEcW+k2NOqi2 QrB+AetsUMMtmR X-Received: by 2002:a5d:5f50:0:b0:47b:69a5:7263 with SMTP id ffacd0b85a97d-47df071c18fmr7139206f8f.5.1783593966991; Thu, 09 Jul 2026 03:46:06 -0700 (PDT) X-Received: by 2002:a5d:5f50:0:b0:47b:69a5:7263 with SMTP id ffacd0b85a97d-47df071c18fmr7139165f8f.5.1783593966534; Thu, 09 Jul 2026 03:46:06 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960634sm51419282f8f.26.2026.07.09.03.46.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 03:46:06 -0700 (PDT) Message-ID: Date: Thu, 9 Jul 2026 12:46:04 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] dibs: loopback: validate offset and size in move_data() To: Andrew Lunn , Dust Li Cc: Alexandra Winter , Wenjia Zhang , Wen Gu , Mahanta Jambigi , "D . Wythe" , Sidraya Jayagond , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Federico Kirschbaum References: <20260707074318.1448662-1-dust.li@linux.alibaba.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/7/26 8:31 PM, Andrew Lunn wrote: > On Tue, Jul 07, 2026 at 10:31:00PM +0800, Dust Li wrote: >> On 2026-07-07 15:43:18, Dust Li wrote: >>> The loopback move_data() performs a memcpy into the registered DMB >>> without checking whether offset + size exceeds the DMB length. Unlike >>> real ISM hardware, which enforces memory region bounds natively, the >>> software loopback has no such protection. >>> >>> A peer-supplied out-of-bounds offset or oversized write would result in >>> an OOB write past the allocated kernel buffer. Add an explicit bounds >>> check before the memcpy to reject such requests with -EINVAL. >>> >>> Fixes: f7a22071dbf3("net/smc: implement DMB-related operations of loopback-ism") >>> Cc: stable@vger.kernel.org >>> Reported-by: Federico Kirschbaum >> >> Reported-by: Baul Lee > > Could you provide a link to the report? Since both reporters belong to the same org, I assume they co-partecipated at the initial report. Also there is a problem with the fixes tag that I'll address while applying the patch. /P