From: David Laight <David.Laight@ACULAB.COM>
To: 'Matthieu Baerts' <matthieu.baerts@tessares.net>,
Pedro Tammela <pctammela@mojatatu.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Cc: netdev <netdev@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
Davide Caratti <dcaratti@redhat.com>
Subject: RE: TC: selftests: current timeout (45s) is too low
Date: Fri, 14 Jul 2023 15:15:11 +0000 [thread overview]
Message-ID: <ca8565fbbd614c8489c38761db2959de@AcuMS.aculab.com> (raw)
In-Reply-To: <3acc88b6-a42d-c054-9dae-8aae22348a3e@tessares.net>
From: Matthieu Baerts
> Sent: 12 July 2023 15:43
>
> Hi Pedro,
>
> On 12/07/2023 15:43, Pedro Tammela wrote:
> > I have been involved in tdc for a while now, here are my comments.
>
> Thank you for your reply!
>
> > On 12/07/2023 06:47, Matthieu Baerts wrote:
> >> Hi Jamal, Cong, Jiri,
> >>
> >> When looking for something else [1] in LKFT reports [2], I noticed that
> >> the TC selftest ended with a timeout error:
> >>
> >> not ok 1 selftests: tc-testing: tdc.sh # TIMEOUT 45 seconds
...
> >> I'm sending this email instead of a patch because I don't know which
> >> value makes sense. I guess you know how long the tests can take in a
> >> (very) slow environment and you might want to avoid this timeout error.
> >
> > I believe a timeout between 5-10 to minutes should cover the entire suite
>
> Thank you for your feedback.
> If we want to be on the safe side, I guess it is better to put 10
> minutes or even 15, no?
Is it possible to use the time taken for an initial test
to scale the timeout for all the tests?
Then you could have a 45second timeout on a fast system and
a much longer timeout on a slow one.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-07-14 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 9:47 TC: selftests: current timeout (45s) is too low Matthieu Baerts
2023-07-12 13:43 ` Pedro Tammela
2023-07-12 14:02 ` Davide Caratti
2023-07-12 14:45 ` Matthieu Baerts
2023-07-12 14:43 ` Matthieu Baerts
2023-07-12 17:12 ` Pedro Tammela
2023-07-13 13:59 ` Matthieu Baerts
2023-07-13 17:30 ` Pedro Tammela
2023-07-13 19:59 ` Matthieu Baerts
2023-07-13 20:32 ` Pedro Tammela
2023-07-13 21:11 ` Matthieu Baerts
2023-07-19 12:13 ` Naresh Kamboju
2023-07-14 15:15 ` David Laight [this message]
2023-07-17 8:19 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8565fbbd614c8489c38761db2959de@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=anders.roxell@linaro.org \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).