netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	netdev@vger.kernel.org
Cc: andrew@lunn.ch, john@phrozen.org, davem@davemloft.net
Subject: Re: [PATCH net-next 1/5] net: dsa: Remove master_netdev and use dst->cpu_dp->netdev
Date: Tue, 6 Jun 2017 11:09:01 -0700	[thread overview]
Message-ID: <caae2343-19d5-eadd-94e5-7dfbe3e5c8bd@gmail.com> (raw)
In-Reply-To: <87d1ahjagr.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>

On 06/06/2017 10:24 AM, Vivien Didelot wrote:
> Hi Florian,
> 
> Florian Fainelli <f.fainelli@gmail.com> writes:
> 
>> -	struct net_device *p = ds->dst[ds->index].master_netdev;
>> +	struct net_device *p = ds->dst[ds->index].cpu_dp->netdev;
> 
>                                ds->dst->cpu_dp->netdev
> 
> ds->dst is not an array anymore, lucky sf2 switch index is always 0 ;-)
> 
>>  	struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);
>>  	struct ethtool_wolinfo pwol;
>>  
>> @@ -829,7 +829,7 @@ static void bcm_sf2_sw_get_wol(struct dsa_switch *ds, int port,
>>  static int bcm_sf2_sw_set_wol(struct dsa_switch *ds, int port,
>>  			      struct ethtool_wolinfo *wol)
>>  {
>> -	struct net_device *p = ds->dst[ds->index].master_netdev;
>> +	struct net_device *p = ds->dst[ds->index].cpu_dp->netdev;
> 
> same here.

It's changed in patch 5, so I did not bother doing an intermediate
change considering we ditch this eventually.

Thanks!

> 
> Thanks,
> 
>         Vivien
> 


-- 
Florian

  reply	other threads:[~2017-06-06 18:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 17:01 [PATCH net-next 0/5] net: dsa: Multi-CPU ground work Florian Fainelli
2017-06-06 17:01 ` [PATCH net-next 1/5] net: dsa: Remove master_netdev and use dst->cpu_dp->netdev Florian Fainelli
2017-06-06 17:24   ` Vivien Didelot
2017-06-06 18:09     ` Florian Fainelli [this message]
2017-06-09  0:01   ` kbuild test robot
2017-06-06 17:01 ` [PATCH net-next 2/5] net: dsa: Relocate master ethtool operations Florian Fainelli
2017-06-06 17:28   ` Vivien Didelot
2017-06-06 17:02 ` [PATCH net-next 3/5] net: dsa: Associate slave network device with CPU port Florian Fainelli
2017-06-06 17:37   ` Vivien Didelot
2017-06-06 17:02 ` [PATCH net-next 4/5] net: dsa: Introduce dsa_dst_get_cpu_dp() Florian Fainelli
2017-06-06 17:52   ` Vivien Didelot
2017-06-06 17:02 ` [PATCH net-next 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers Florian Fainelli
2017-06-06 18:09   ` Vivien Didelot
2017-06-06 18:12     ` Florian Fainelli
2017-06-06 18:33       ` Vivien Didelot
2017-06-06 18:25 ` [PATCH net-next 0/5] net: dsa: Multi-CPU ground work Vivien Didelot
2017-06-06 19:20   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caae2343-19d5-eadd-94e5-7dfbe3e5c8bd@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=john@phrozen.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).