Re: [PATCH net-next 0/2] amd-xgbe: add support for AMD Crater

[Tom Lendacky <thomas.lendacky@amd.com>]

On 10/18/23 09:44, Raju Rangoju wrote:
> Add support for a new AMD Ethernet device called "Crater". It has a new
> PCI ID, add this to the current list of supported devices in the
> amd-xgbe devices.Also, the BAR1 addresses cannot be used to access the
> PCS registers on Crater platform, use the indirect addressing via SMN
> instead.

It looks like this should be a three patch series with new "Crater" device 
support, followed by a quirk/exception for the BAR1 address issue, and 
then finally your first patch being the last patch so that the device 
isn't enabled until the final patch.

Thanks,
Tom

> 
> Raju Rangoju (2):
>    amd-xgbe: add support for new pci device id 0x1641
>    amd-xgbe: Add support for AMD Crater ethernet device
> 
>   drivers/net/ethernet/amd/xgbe/xgbe-common.h |  5 +++
>   drivers/net/ethernet/amd/xgbe/xgbe-dev.c    | 33 +++++++++++++++++---
>   drivers/net/ethernet/amd/xgbe/xgbe-pci.c    | 34 ++++++++++++++++-----
>   drivers/net/ethernet/amd/xgbe/xgbe.h        |  6 ++++
>   4 files changed, 65 insertions(+), 13 deletions(-)
>