From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: phylink: rename 'ops' to 'mac_ops'
Date: Sun, 29 Mar 2020 13:33:47 -0700 [thread overview]
Message-ID: <cacfd159-4881-5c35-0e63-decac322a9c7@gmail.com> (raw)
In-Reply-To: <E1jIaN7-0007lh-3p@rmk-PC.armlinux.org.uk>
On 3/29/2020 9:01 AM, Russell King wrote:
> Rename the bland 'ops' member of struct phylink to be a more
> descriptive 'mac_ops' - this is necessary as we're about to introduce
> another set of operations.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
[snip]
> @@ -679,7 +679,7 @@ static int phylink_register_sfp(struct phylink *pl,
> struct phylink *phylink_create(struct phylink_config *config,
> struct fwnode_handle *fwnode,
> phy_interface_t iface,
> - const struct phylink_mac_ops *ops)
> + const struct phylink_mac_ops *mac_ops)
This function signature in include/linux/phylink.h needs changing to
reflect the change in the argument, with that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-03-29 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 16:00 [PATCH net-next v2 0/3] split phylink PCS operations and add PCS support for dpaa2 Russell King - ARM Linux admin
2020-03-29 16:01 ` [PATCH net-next v2 1/3] net: phylink: change phylink_mii_c22_pcs_set_advertisement() prototype Russell King
2020-03-29 17:19 ` Andrew Lunn
2020-03-29 20:29 ` Florian Fainelli
2020-03-29 16:01 ` [PATCH net-next v2 2/3] net: phylink: rename 'ops' to 'mac_ops' Russell King
2020-03-29 20:33 ` Florian Fainelli [this message]
2020-03-29 16:01 ` [PATCH net-next v2 3/3] net: phylink: add separate pcs operations structure Russell King
2020-03-29 17:23 ` Andrew Lunn
2020-03-29 20:42 ` Florian Fainelli
2020-03-30 10:08 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cacfd159-4881-5c35-0e63-decac322a9c7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).