From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2-next 1/1] tc: add json support in csum action
Date: Tue, 5 Jun 2018 12:56:21 -0700
Message-ID: <cae5b0b6-576f-5641-5c51-695ae54eb9c4@gmail.com>
References: <1528227039-21831-1-git-send-email-kleib@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
        kernel@mojatatu.com
To: Keara Leibovitz <kleib@mojatatu.com>, dsahern@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f68.google.com ([209.85.160.68]:37795 "EHLO
        mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752003AbeFET4Z (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Jun 2018 15:56:25 -0400
Received: by mail-pl0-f68.google.com with SMTP id 31-v6so2189537plc.4
        for <netdev@vger.kernel.org>; Tue, 05 Jun 2018 12:56:25 -0700 (PDT)
In-Reply-To: <1528227039-21831-1-git-send-email-kleib@mojatatu.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 6/5/18 12:30 PM, Keara Leibovitz wrote:

please add some words here. e.g., add example output

> Signed-off-by: Keara Leibovitz <kleib@mojatatu.com>
> ---
>  tc/m_csum.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/tc/m_csum.c b/tc/m_csum.c
> index 8391071d73f2..67481667d9d2 100644
> --- a/tc/m_csum.c
> +++ b/tc/m_csum.c
> @@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg)
>  	char *uflag_5 = "";
>  	char *uflag_6 = "";
>  	char *uflag_7 = "";
> +	char buf[64] = {0};

initialization is not needed. It is set before use.