From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA2F9309F09 for ; Thu, 5 Feb 2026 09:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770283025; cv=fail; b=BRBLtXh2EHxIvId4LB6be4BdiRIQxJ5bXKU0yHZIJ+qVJr3EI8YbnNggVFmnaTDBpBoQ7hyekTP/VHjAOwaO6yBqrpkjfWmaWpFUidPFA2OoASU/S27d0FP3h1/L63G389S3iTqThHva+KPehAp/CXaeareRsEOv1CTTiUJHZOA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770283025; c=relaxed/simple; bh=KEdkT20i8yBICwqVzBw71iOAo3rcmqTd2cdl3ioKZjM=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=CSBvHw3UMVc89D+ZWIJ7QJCwVMl1Iv4jk2vvtkSuQGLBOx4dqmcmd/va/uldfoDCRNpvGSkPfHntgPilOWE2g7GPi8SuMg3Y3QECXgIOUGN7mvWyhH65yWKwNUsJB7axZDUWU9Pcc/h0FaMfHcj7hPSa3ZDCSJyZ0Ox1JGxvQNM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=E+jhpIM4; arc=fail smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E+jhpIM4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770283025; x=1801819025; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=KEdkT20i8yBICwqVzBw71iOAo3rcmqTd2cdl3ioKZjM=; b=E+jhpIM48A4b3G9tPc2sLKec6DWvLUG+KXKdlVpnbjJJBrTiD9plm9Kv O6cphW8TELN/06I7yQgdjbKlMe1tG+Ne+yfZf08DZqbvBIc0OtzMo7ytt cW/anz/3LVLTVOPsF24BK1tCwhPpVkWZ9L0181qIVNbWyEEZoX7vp/8aW B/hCwODtDn/IsO1iUqEr7D6c+Iiyt297mInLPhQrKR9Gz/zxcIFh4Mnvr m5KKmX4YYlq3dfUb0kvidzBZYSzWGGw/U7iPuOjudlMlvtV/bZheeyoCj 2EYyAN9Rvtahn0M/UuAShYc5UaqUJJGQX7wYL4OG2Bd66P0d0HPnm3GY0 g==; X-CSE-ConnectionGUID: rT5KRCiiRDytsSGASqlbRQ== X-CSE-MsgGUID: aJzCBBb+Ru64AJ3T4IM8PQ== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="82848804" X-IronPort-AV: E=Sophos;i="6.21,274,1763452800"; d="scan'208";a="82848804" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2026 01:17:04 -0800 X-CSE-ConnectionGUID: 6an6RpIuTkC2qUVngDiMiA== X-CSE-MsgGUID: 1e/jPabhS3uFIAtoMbCEKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,274,1763452800"; d="scan'208";a="241097472" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2026 01:17:04 -0800 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Thu, 5 Feb 2026 01:17:03 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Thu, 5 Feb 2026 01:17:03 -0800 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.50) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Thu, 5 Feb 2026 01:17:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HhN7qp+w7RDQ189OI3+BeWvV692BhK8OGssqB5BY2zoaA3ntbE2+fVAgOP0ymVD7ZU1A+sySi0C8vbPRsXNtL8+M9OrdVSI/SvNIew3g6+x8wTJxmxT6gEYe4aBkcn3gFVELSpgh5PBiHBYIquDiy4iOEufCU3hMYH5j0TfT2qSYdeeHXsU9K0Q0z9f2tIa076w3mwqQFU5mXYH+nvRHNRaj0BfYMNmVFxoYyHtFDUl6ra6l78IN5GF2S4mNewnmOcs8I99DqbLi3Liy2CotwPGOaXnMiKnI88/bzn2p/V6p9cC9QdAsEnvBxTW+ZgbZiK8IXbZb3AxyLmZcrPMykw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EM/L7W5R/Kj3SjD6sxGrq9yYB3rc+/vnxdDORYkkmMk=; b=WH4EeTb9mBHp+3W2m0JIMaAMAdnsmcp7vbLnRYBUN/baTULqagFCdMXEM1OkYLViJyjcZHqoTBX2t1dr1+SYska8PwwH3NeIaH7bB/zU1z2+dK3BEuqk6GJ3NXTvfMZI8JqUZ6L0ussOsoHnSKhzjUullj4mYB3S2ZzwaSVU7bGL6uvTVPODttQZFOs/tpgKdzLsOumDRZjDYSLf1gQShLGVzjunxvzvHomKGo99kxXKnC/cl57UCaCs1Y4fQSp3usSBNCXvt6moCXu4/g3rxKDI10dfExPDcqDnROKMlhxli43EyZ7yuTc4UYZ8/V2eKTvw8UXL8jbQGEmzqTe5fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS4PPF814058951.namprd11.prod.outlook.com (2603:10b6:f:fc02::36) by IA3PR11MB9061.namprd11.prod.outlook.com (2603:10b6:208:57c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.12; Thu, 5 Feb 2026 09:16:56 +0000 Received: from DS4PPF814058951.namprd11.prod.outlook.com ([fe80::1fee:366b:ed73:b459]) by DS4PPF814058951.namprd11.prod.outlook.com ([fe80::1fee:366b:ed73:b459%5]) with mapi id 15.20.9587.013; Thu, 5 Feb 2026 09:16:56 +0000 Message-ID: Date: Thu, 5 Feb 2026 11:16:50 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 iwl-net] igc: fix null pointer dereference in igc_eeprom_test() on NVM-less devices To: Kohei Enju , , CC: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , References: <20260205085030.60080-1-kohei@enjuk.jp> Content-Language: en-US From: "Lifshits, Vitaly" In-Reply-To: <20260205085030.60080-1-kohei@enjuk.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TL2P290CA0007.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:2::9) To DS4PPF814058951.namprd11.prod.outlook.com (2603:10b6:f:fc02::36) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPF814058951:EE_|IA3PR11MB9061:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e370ee2-8322-4056-ef58-08de64974ee2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y1owZ2VtUzFKQ1hza1lEekErNkN1UGRlY1dNRmdranYvRWRxeXpNbmFnaitQ?= =?utf-8?B?d3FBTTBabWZ4MVhMQ1F6VEhkdis1bTRmbUkrVnF4eVh1c0hDNXhPSUdxalZx?= =?utf-8?B?SGVuaWNqSUxGVFgvWEJ3OFBYWWVPYWVWYTFIM0JFQlRqajVPWnF1YkxKMFky?= =?utf-8?B?V2JsSDk3czhyUFZESDFjZzVOZ054czcyVWdrd3VSa3VKSVdUb2dmcDU2Q1kv?= =?utf-8?B?aFF5UEcwcXVnSUM5SUpyMzBFQ25OeEdRbzdyUVlRS09vaTNSWUFRRHJ6MHVt?= =?utf-8?B?ZHc3T3FudFR2dzVBcGxjS1oyb29xdG1FbitWajdDNnZvaWxWRS9FeVpNSWJi?= =?utf-8?B?MnFrcFVrcUIzUkczY0FvVytIcTc0MUh4b1hjSCtFRzlXWHVMQTY5ek1GZ082?= =?utf-8?B?ZFNiWTFKWGZjNHlrQ1ZlSzJsSVF1TGcya1NrS1hkNjRkMW5uZ1k0UzJCQkhW?= =?utf-8?B?dXQwR3Uxc2ljQTN5NjRST1EwR3FtNEF5MEJVYkdldm1YeFBPWHBZS2llNmRJ?= =?utf-8?B?S2JabG5NTGd6aW14Zk0reTRGNXhXSmhNNDRSVndkRDRwUDFIR2x6WSsrdWdv?= =?utf-8?B?QlFmOWt1eENZQTNwalBwTjJ1V0JpVGZzQmo3Z0NBS05VQXRXYkwvZUUzYkkw?= =?utf-8?B?czJJMHBQaXU0UDh5eTVtdXVvWGV0d2VqSzV1eUZVQ2JRbWlNa0U5L3o2Wkp6?= =?utf-8?B?QzZxbHZlWStKMHE5bnpCeXJKaWh0UVJVR3Jua2dyQ3RldFMrYmRobDVLbnZD?= =?utf-8?B?bThjaG9vOSsvTUtuT2Q0UThTYkJDNUxnZXduWWZ4dHJ3c01HUlBmenFxNGYr?= =?utf-8?B?MGMxOTRkMThHQ3BtUVZDeHBEZ3ZQN2VxcXV6U2NmMDQwZ284T05TUzZseDVh?= =?utf-8?B?bHBlNEpFWkZFYklFemQzLytiRko2d3BoemY2ZXZvcmZqT1NrZGNmWEI0TjB3?= =?utf-8?B?dlhRY3RZTWppUjlSTDlZM2dsUHZteGpaSGl0anRybEhkQVB4ZllxenpzK1hG?= =?utf-8?B?QmhxY240S1p6Qkw3RWxJekc4M0d3eWNDcFRNQ0VzNzhEUXBaZlZSL05YR0h1?= =?utf-8?B?aEpERVl2aHl4Q0dTcGRJMWo3OHFLb1gxRFpSZVVLK0l3djdwanlIY0lKTlJz?= =?utf-8?B?cVpWejl3WkVIdkorVjFsN1N0U09FRUg0WEhXUzFGaTJHdmU5ME15WEE0U09q?= =?utf-8?B?aVdZbS95Wm8vRXMzdmFQcjFpTENicm81NVVORGdKQUFnYkdoODB5QjFTTTlE?= =?utf-8?B?a3B4YXJLY2hvbnhZOGhIcWFHK2FVNkYyOHBpTTBPa3BzSHhrazZXY2daS3VG?= =?utf-8?B?a0ZDZTdsU0ZETFZkakxLamRIU21ONTAyVEVnaEhjYnh3R2xROEtyRGlIa0py?= =?utf-8?B?dk9NTldtV252NUI4SmVDTkhZWEJHdUVWWHRCUTk1Y3k2OWhjSDBUMGZIQWFC?= =?utf-8?B?YmdUL09EY3dNNXJjVzhtVkJTNWtYWlc0UmRmdDZwWi94K3d3M3J0UnlaWGtx?= =?utf-8?B?bzV1NWxJNDhXd2s5ZHRpU21vdXEyN1phUFFwWmppdWJycVBsSW5JMWJXNGM3?= =?utf-8?B?TTVsVnRzd01iT0JuVXozMjJCOUQ1RzArZ3pWdnVQQVVTMDRZWXVIdDZUYlcy?= =?utf-8?B?RTRLRlJJS1pMM0lHL1pSSk5WUHRBY092Q0NVN0dZWUE2RFJqaHUzZzR4elBa?= =?utf-8?B?L2w3S2FjMEhhazhNUldPeit0bG11RVRJbUNhRHo4ZWplZGd0QzRZQ3VSTFVE?= =?utf-8?B?VW9QWkplU2Y3UGJGQXArUGtoYi9waVROZWkzYXRvVEtxaXRqM3hSS0d6Vklj?= =?utf-8?B?SGxQVzgyL2VaQ3h0c2grbnV6ZlR0dFVibEYwRVNkU2FROEFWbStvSDlZMlR2?= =?utf-8?B?WHhUTDFsckhvdlhpV3dGaVRmNUxBSUVqaG11SmZ0VXVBMzRKQURsUm5zTzhv?= =?utf-8?B?OUhETTBaREQ5NVpEVFRKYWkvRWUzaU90V0g2a3h5bXRaSnU1MVVNUUhQa3FE?= =?utf-8?B?L1JuTnFHUmx0UWdUYlRoOTJ3QWwzakRKMlNmNS9qZkp0aEJDdTlqbHp4c0g4?= =?utf-8?B?MmZJaUcvcXBuVEdWSmhJcjkxMk9xS2lQcXpDYm5IUVBBR0VWM0F1ZzNkVGgw?= =?utf-8?Q?WmVU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPF814058951.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWN3ZFA1anZkbjJ3eDU2eWYrcldKbGhuZG9sdzE3dkllZ05HU202SGIrL1Q2?= =?utf-8?B?WW41bFBDemlFVkFhZHdwbjlBNXlUdTVSVldJcEYyQU1CNDY0NjhLMldkUStN?= =?utf-8?B?VURGNTNRdDhTeU9DeVlKSHN0YW0yZkJSRFF4czFXNE04eEpPVlc0RFRSSmZN?= =?utf-8?B?OEJBa2N2UTNkejBzaitURW5YMUlUWW1mVElJb1JRdUdUeE9LOGZveEc0MjBE?= =?utf-8?B?cFlDVW5YeFF4SDBNWThTRWFUU2wvNWR6RGZNWFQ2NWJ0Y3o4Uzh2aVgxa0Vv?= =?utf-8?B?Nyt2S3U4ZXZZaVRSTEQxU3Mrak1iOHlNZmsxOEZ4RWZvcnJReE5pUmdjY2Fu?= =?utf-8?B?VGJIZFp4YmV2MVFMMVlLNXNpY2owOGFmcUo4WGVhMUxNem45bitjZUp3U0Rw?= =?utf-8?B?T3BDMHgrWkczL1BIZ21IREtaSjVQY3ZwbzRkWVVubTBIblZYRDEwRXNpTklS?= =?utf-8?B?UTZ2R1VBN1FKOUVKUmNOSExMNU1DcHBCdHRaWG5oTEtVVnY1dGxnclFKbHpq?= =?utf-8?B?Y3B1bDlrQTZTS0lhcDlCcFdMSTl0aDQ4ck5UWnp6R0Q1eUJZRzhhZjBDbkdE?= =?utf-8?B?WWFKVXdvU203OXBVVWoveEdmeld0Zm9XZW1VRkNyekoyQ1hldmhiRFlQNzFZ?= =?utf-8?B?VUJYU09BRzZxR2RaVmZUOThOZzVCRzlvV2F2aFRISHFKZUpSSUpHTmxyaDR4?= =?utf-8?B?YXUyRVQ5enRaSGdHTGt4Z2tVd25NVEhrNnB2RXk5NnNUNE9BeXo3ZDBzWlUw?= =?utf-8?B?bVUxK0w0QU4zaXhReWRHL2JLWDRPY0tzWnBLZWNtQVo0T2lROUZIS1JKT3NG?= =?utf-8?B?RUF2dUNwWDludmxMR3EyTys3djExUTMvZDBaWHJldDlWRUhKQlhJamNRUDZ4?= =?utf-8?B?SEdxZHc0VHNHWUx3M09vR1pRRmUxbHZONyszZmZVSnJLVFBKVFVjWXhMdVYr?= =?utf-8?B?SnZxbHVqVlBvVWlZMW9FYkdOaW5kMVJJR2Jtcm1aa0RFVHpUeWJTMHBGd296?= =?utf-8?B?czNMcXBINE43SkVzZjU4enNUajkwUmgrbHpBMXpSL0lDQW5ObXFxSDNEampN?= =?utf-8?B?NHpzaUQ4YURnUngwUktLWWtJbHE2a3ZlMTM5ZnhHcEYrMldvSzMrblhwWFBT?= =?utf-8?B?d2Rzb3pQZlQ0NnNhRGczV2RlYnV5QkNtb2ErV1V1N2Z0b0w0Y1BPSU1Uek14?= =?utf-8?B?NEJWNGtHa3U3QnVFeXpWSElMU0JCTlM5RFdQbURNZFVCdHpWUzhKNVY5WVZs?= =?utf-8?B?NkZicDdNQ0FSYk5NYVhZNEdGQnpsWGJ4Vk1yQlRpR3ZGdWVjcEQwWldZMGFO?= =?utf-8?B?TEJVcWZOWkNUSkhTVmw3TEY4R3laazlod3Noc0JkaS9xNGFaUkZSY1NxcWg2?= =?utf-8?B?cTJCYXM3L3ZQUjl1emdZVXpRbjdBSjZ6dzFtRkdDVHhabGMzdm5mMWoydkJX?= =?utf-8?B?M0FQNnZ6L3JyRlJwSlhveFhEbUViVmhscjFpb3Z1VnY3UnBSRytkUmNCaWg4?= =?utf-8?B?bWxUbHRORkJIREFhWEdxMDJQanpKTDRDcFFVWE4vZHpDLzRndGtDWnVFVjJH?= =?utf-8?B?ZmtSRUJNcks3T0ZFQkpOeG5oS0p4SDNCSmViQzBDK2c4Umx5TEd3T1RkeDY0?= =?utf-8?B?NEJZKzhmNVdiTnlZeXVzMzNmRmo0ZHFxZWloaXdVTE9CeUdOY3Z1cDlNT2hO?= =?utf-8?B?V0U2TnlMNlFtL3U5WWt2UndWY1dvU1hsWFZUT3BsTmVNMEg3RFdrYW4rUmRQ?= =?utf-8?B?ME5kc2ErSngxcW9OU2JWTnMxM1loWWNEek4vZ2dtL2lYRERqL1N4elZ2UXhk?= =?utf-8?B?VHhHaHREeXBpL0RxbHpleUxGbU5tc1psZ0w0L0lkajB4Z096ZDFpNkFlZmpi?= =?utf-8?B?amduZXZlOWVmWVhFZGNDL3BpWXl2OExGNGFXTlRBcERqbExKOGJKZ0M2Y1Jk?= =?utf-8?B?RTFKSnpMWDFhU0g1aDludzdBUGdtM2JsdUM3L0YyVzh6ajN3VVF6WVJ4Y0tT?= =?utf-8?B?TjEwYVJoWklkd1VyVTk4SFNrdzZIRGlZN2VhVXFHaHhIR0thVXJjbXVaUGNL?= =?utf-8?B?cll3S0JGb2ErdlhaejdrTUFmNXpSSC9ZN2tqbnAxRjFWci93VkM2VVVjV2RL?= =?utf-8?B?TWJNaGgzL0tldHV3bllCcERabElxcjZoZzErOWtZRlViZ09oWGVCd3JjdjZa?= =?utf-8?B?UitsNFkzNUM3U3F0SGlMUm5qdjI3SDlxbnJPUFpIZTY0dTVYTm9jZkNTTkxV?= =?utf-8?B?Qi9uR1kydW56NGErdGZib0xyc0UzYXhYQSsxUnRSU1pXS3dPMVF5VjBJWitP?= =?utf-8?B?UU40dUVNVTJZdDFtSEY2dXlJN0hibE5OSnAyS3NNRmk1bFpJd1FwWVNQNVVq?= =?utf-8?Q?c53vKoiyguF3Qzwo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8e370ee2-8322-4056-ef58-08de64974ee2 X-MS-Exchange-CrossTenant-AuthSource: DS4PPF814058951.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2026 09:16:56.2049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9mIH77+1PZj8amG95MCinMnBbe/5wo7pnd5MX36goj5mYIUCj/+zFwqmTLWDGjPzFYQJz71sHdFBKBvAA2QV/K7CrolPPd/lvgNsZwgr33k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR11MB9061 X-OriginatorOrg: intel.com On 2/5/2026 10:50 AM, Kohei Enju wrote: > On devices without NVM, hw->nvm.ops.validate is set to NULL, therefore > functions that perform EEPROM-related operations such as > igc_ethtool_set_eeprom() and igc_probe() check for NVM presence in > advance. However igc_eeprom_test() unconditionally calls > hw->nvm.ops.validate(), potentially causing a null pointer dereference. > > NVM-less devices may not be common but possible, so add NULL check > before calling hw->nvm.ops.validate(). > > Fixes: f026d8ca2904 ("igc: add support to eeprom, registers and link self-tests") > Signed-off-by: Kohei Enju > --- > drivers/net/ethernet/intel/igc/igc_diag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c b/drivers/net/ethernet/intel/igc/igc_diag.c > index a43d7244ee70..973d26a5a6c9 100644 > --- a/drivers/net/ethernet/intel/igc/igc_diag.c > +++ b/drivers/net/ethernet/intel/igc/igc_diag.c > @@ -158,7 +158,7 @@ bool igc_eeprom_test(struct igc_adapter *adapter, u64 *data) > > *data = 0; > > - if (hw->nvm.ops.validate(hw) != IGC_SUCCESS) { > + if (hw->nvm.ops.validate && hw->nvm.ops.validate(hw) != IGC_SUCCESS) { > *data = 1; > return false; > } Hi Kohei, Thank you for your patch. Since there are no NVM-less devices I suggest removing the flash-less code entirely from the init flow.