From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3231C433EF for ; Tue, 22 Mar 2022 08:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232026AbiCVIyI (ORCPT ); Tue, 22 Mar 2022 04:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231723AbiCVIyG (ORCPT ); Tue, 22 Mar 2022 04:54:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1CF857DE0B for ; Tue, 22 Mar 2022 01:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647939152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iyMWMxVWAGisdvJOYs+VVN86dCYSEjTUHb7tjwWEipE=; b=KwzOqbYqpC5pj8HXzAAS3YnGQcDdu8mmUq/DvQW3MADj5ZGeSopQhFp/IJEoBN1T3x3MJA 27/zfCNwye4se7lzUT2SwhUwA3YSyniQ9F3Zq2VPzX22sdEWQfh9qpgxrQxdRob00cZSmX j0mYE25KrVGwbDvWGDYP9in8wcKKTtQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-O62f5W6gN4yD-dwODoKAjg-1; Tue, 22 Mar 2022 04:52:30 -0400 X-MC-Unique: O62f5W6gN4yD-dwODoKAjg-1 Received: by mail-wm1-f70.google.com with SMTP id o19-20020a05600c379300b0038c7117460dso543408wmr.6 for ; Tue, 22 Mar 2022 01:52:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=iyMWMxVWAGisdvJOYs+VVN86dCYSEjTUHb7tjwWEipE=; b=o36S+sFQ7pz8Hwl71W/UmmF6DexuGv3JqmW8l2NEyY1y35BUs6mGT9NcA4zuHrOAWN vBULukEWGTZQrCAabSjebhq9fJZd9q7EkqwJJJlalb8r7ok3KNo3twt6NG26hCE1BDLY 1b4vpi2cQzxtUDQ/a08X9xM3IxKZRKwEkgOQwlBoBMKkYndjrdym/JHXNHS0qu9YYWTZ FMupAxs51eJvmZhQC2bOSkCkKJ9pWTuOh9Qw23iqKqPNo7+OUfWGLCWH1wlJuvC3QlS8 B/JAb2y8NwinEZNKeoIeKQtevzh5fBPWKH4XU2+5UZLs3/EKphvcvWpa5W1bjVwIZd3L np6A== X-Gm-Message-State: AOAM531RBVPleMme0uHLh2gODGsK5r451mTGHNm92i6yOANfBUH0l10a TcJCOWmDHuiPNkTrN6lHDjnvEU9/VJLiOrKXuAA+WWQdpOv8KVXWRSXJNPlStS9Hta3j50X3BZA dDBQVwf5Om1/lMqe4 X-Received: by 2002:a05:6000:1e12:b0:203:ed33:8981 with SMTP id bj18-20020a0560001e1200b00203ed338981mr19039650wrb.525.1647939149583; Tue, 22 Mar 2022 01:52:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRdYdMvWp8eyiQYPO+MnNtfXHXtjHOuPL626IQMjpxjgJQt/FKMstA1whF/Tm2qk4+kGEtKA== X-Received: by 2002:a05:6000:1e12:b0:203:ed33:8981 with SMTP id bj18-20020a0560001e1200b00203ed338981mr19039631wrb.525.1647939149357; Tue, 22 Mar 2022 01:52:29 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-232-135.dyn.eolo.it. [146.241.232.135]) by smtp.gmail.com with ESMTPSA id 185-20020a1c19c2000000b0038a1d06e862sm1433369wmz.14.2022.03.22.01.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 01:52:28 -0700 (PDT) Message-ID: Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator From: Paolo Abeni To: Xiaomeng Tong , davem@davemloft.net, kuba@kernel.org Cc: aelior@marvell.com, manishc@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 22 Mar 2022 09:52:27 +0100 In-Reply-To: <20220319043606.23292-1-xiam0nd.tong@gmail.com> References: <20220319043606.23292-1-xiam0nd.tong@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, On Sat, 2022-03-19 at 12:36 +0800, Xiaomeng Tong wrote: > The define for_each_pci_dev(d) is: > while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL) > > Thus, the list iterator 'd' is always non-NULL so it doesn't need to > be checked. So just remove the unnecessary NULL check. Also remove the > unnecessary initializer because the list iterator is always initialized. > > Signed-off-by: Xiaomeng Tong This looks like a net-next change, but net-next is now closed. please repost 2 weeks, thanks! Paolo