From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5322128725E for ; Mon, 29 Sep 2025 11:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759144528; cv=none; b=IQpryMOmi0v3S7yfjsG35BJxMQMzY8XPLWC/na2ZjkivlYIIc6e/SINk+2ozUOjxLNxLZOQq/G3orDB4zVqpdsm3Q4zcH7Jkzp/HsOhkmqW5xB1bC0uKzqdp9B9e3rcqmt6NbQ9kA6ICOfS/SBT6Lt92QKjoX4Sqn6M/yrngzTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759144528; c=relaxed/simple; bh=h3/UTG4XkimSkzuTqoSelXZrRu9xdoi2NXZzzLD8Xs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n3OKWL5dEgr9awhFQUxyja3ixmTYJzo53ior6qYf1CjIjz73eENaCKAPmUGMa1hxXwIgCT2zvUkYFmlNg5Z5hlcFBQeBPykZjdoBkR3wgiTmE0gfh6m9ljE7Jd0k94wTv4EQb58idbhzXaeqvIlmzpJKJVPrrBWDTHlfQ3YGa+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=O+1clHQS; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="O+1clHQS" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-62f24b7be4fso8092761a12.0 for ; Mon, 29 Sep 2025 04:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1759144524; x=1759749324; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PifF24bdCajykuJnMbWaG4hKvbpCIsKH6sxZ8dNTu4w=; b=O+1clHQS/2tJrwWKhpfbykq0JK5b4dynaBEXQxWJtbUug90OrpThqp9d0AKacyI7Fg F6kTfmym8lEAf+bzcsuToj5sjIMrk0jJXPO3GakTYrIjlO4RqlBBwWTk5bJYBn3nRuj1 L0JnjkJE71v2pvKr3DykclODxeWUHOcnhbvThAB0+kqTloTPAMRaKp0hIHWWb7CJlry3 cCp41hpZxvSnpQJAiNTB0JMPuOqXmpzSX2KsOJZgYe8tgWDlqwlpgdpJo+PDxAcvVL2r eZTZGsqOGcF6oJ9ey3pIZF3B/OgppH4b2iAx4ZelESRkao1mECU7tB4+bIcYxv8FA4Q6 6Y7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759144524; x=1759749324; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PifF24bdCajykuJnMbWaG4hKvbpCIsKH6sxZ8dNTu4w=; b=QYBSgKB0Wupm8kMZ5Gwp1gofobQgnAJc9P5MF7rsry4nZUx+ENBTyw57Wto9NrA6Y8 8DyHaaiBUZNcimNmhlaZNPz9VwhhtffyWIVXpjkCQNmufpFHf5w39LrINphuZheps2ma 9yH23k13AA0SonWMoEeFjGFiVUHo+75t+osIUE7U/nbSow6cyqVvWa6vkk6LBmqpOQ23 Ugk/X2yJoSqXLw65FO7GbZ3CV4q42PzWDChF+iq8FXc6LbaWfaq0KbOabotJwouwvSrO oejBknf/Bz0p+w3gak4umRDJnmiT+5JGf0Wp33GndHBxYjGiXlUR/6+X9kp4QydbrvO2 AOUQ== X-Forwarded-Encrypted: i=1; AJvYcCXNd3cNuvt6GooabhF0FUQsaYYIGAg0UcrRZTMEtExoxqnY2kcKUuIVi9m/FK0E1PJvKdZFWIw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+3SGl1VzirDSO+ErSreKvTai+YIc/74X4Pj+5fufq/eeDMkGE tMRFbAnWnWKlq3ZfpbJ9Psvqy/rqAI6C5XNp3ZPQI+w9GmmHogDyrKbIt2X9hgswHlU= X-Gm-Gg: ASbGncse2Uryh3ZCgP9x9uGhVFn3aRyrpIHvptKkU1EZa/btdMDWKZJERNKtUw8NVXM BmmRB4c2aGt9KDBxuosSQg/bk50BQQCgxFxtTtlzlYedqTeGRCz4BMk9PxsQ0vLw+Qef+uKc3Bd O/VIkh8VJ/gHqWmecQ6fpYHHnJjmKwsEUAOVAw5xfU63EfEF7HgdyGPuy9rB3IuKPV8VlbwsqMP b1y0C70rr6cHztn1fLWM96A+0ZjeKtPv5mjJ0VLrWQyWOJ4U7YM5gN5fzEPFs9hKROd3gU3xxeB 5Xt5yLHKQpBkS2u/HaHXCAdswyNtylix7A9Yr9E03oJgIcx2xAeuFYJDqZH9Z5/9DR97uBkLNSd VVL/dKgKL8r8He1deoYmh5zFEg6V+RD/XCNpu787CensCjyLyVUJdqSiP X-Google-Smtp-Source: AGHT+IGKtfwVrcf/9LCpdhNG5Odr6DXnkk/naEi01kTwxS6i/QfpYsAQbOXGFIMNLYg9a7IpP8c8Dg== X-Received: by 2002:a17:907:da9:b0:b0c:fdb7:4df5 with SMTP id a640c23a62f3a-b34b8b93d6emr1919146266b.18.1759144524527; Mon, 29 Sep 2025 04:15:24 -0700 (PDT) Received: from ?IPV6:2001:a61:13a1:1:4136:3ce:cdaa:75d2? ([2001:a61:13a1:1:4136:3ce:cdaa:75d2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b3c9ab5d70esm319990466b.21.2025.09.29.04.15.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 04:15:24 -0700 (PDT) Message-ID: Date: Mon, 29 Sep 2025 13:15:23 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface" To: yicongsrfy@163.com, michal.pecio@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: marcan@marcan.st, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, yicong@kylinos.cn References: <20250929054246.3118527-1-yicongsrfy@163.com> <20250929075401.3143438-1-yicongsrfy@163.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20250929075401.3143438-1-yicongsrfy@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 29.09.25 09:53, yicongsrfy@163.com wrote: > From: Yi Cong > > This reverts commit c67cc4315a8e605ec875bd3a1210a549e3562ddc. > > Currently, in the Linux kernel, USB NIC with ASIX chips use the cdc_ncm > driver. However, this driver lacks functionality and performs worse than > the vendor's proprietary driver. In my testing, I have identified the > following issues: True, so we prefer the vendor specific driver if it is available for a certain number of devices. We accept that as a given. The exact reasons for this preference do not matter. Now , lets look at the change log of the patch you want to revert: Change all the ID matches to specifically match the vendor-specific interface. By default the device comes up in CDC mode and is bound by that driver (which works fine); users may switch it to the vendor interface using sysfs to set bConfigurationValue, at which point the device actually goes through a reconnect cycle and comes back as a vendor specific only device, and then this driver binds and works too. This tells us that usbcore selects the wrong configuration for these devices. Can we remedy this via udev? Not well, there would be a race with the wrong driver triggering an unwanted network setup. This would be better solved in usbcore with quirks. Regards Oliver