From: Ying Xue <ying.xue@windriver.com>
To: David Miller <davem@davemloft.net>,
<syzbot+df0257c92ffd4fcc58cd@syzkaller.appspotmail.com>
Cc: netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
linux-kernel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: KMSAN: uninit-value in strcmp
Date: Tue, 8 May 2018 21:12:14 +0800 [thread overview]
Message-ID: <cb60d6f0-4e32-b360-d1f2-032ee7777fcd@windriver.com> (raw)
In-Reply-To: <20180503.152213.740988890883315228.davem@davemloft.net>
On 05/04/2018 03:22 AM, David Miller wrote:
> From: syzbot <syzbot+df0257c92ffd4fcc58cd@syzkaller.appspotmail.com>
> Date: Thu, 03 May 2018 11:44:02 -0700
>
>> Call Trace:
>> __dump_stack lib/dump_stack.c:17 [inline]
>> dump_stack+0x185/0x1d0 lib/dump_stack.c:53
>> kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067
>> __msan_warning_32+0x6c/0xb0 mm/kmsan/kmsan_instr.c:683
>> strcmp+0xf7/0x160 lib/string.c:329
>> tipc_nl_node_get_link+0x220/0x6f0 net/tipc/node.c:1881
>> genl_family_rcv_msg net/netlink/genetlink.c:599 [inline]
>
> Hmmm, TIPC_NL_LINK_GET uses tipc_nl_policy, which has a proper nesting
> entry for TIPC_NLA_LINK. I wonder how the code goes about validating
> TIPC_NLA_LINK_NAME in such a case? Does it?
>
> This may be the problem.
David, you are right. This is absolutely a real bug. As you said, we
didn't validate TIPC_NLA_LINK_NAME attribute in tipc_nl_node_get_link()
at all.
I will submit a patch to fix the issue soon.
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
prev parent reply other threads:[~2018-05-08 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 18:44 KMSAN: uninit-value in strcmp syzbot
2018-05-03 19:22 ` David Miller
2018-05-04 1:58 ` Jon Maloy
2018-05-08 13:12 ` Ying Xue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb60d6f0-4e32-b360-d1f2-032ee7777fcd@windriver.com \
--to=ying.xue@windriver.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+df0257c92ffd4fcc58cd@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).