From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Jiri Pirko <jiri@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next v3 1/7] net: devlink: Add unused port flavour
Date: Sun, 4 Oct 2020 09:17:55 -0700 [thread overview]
Message-ID: <cb6ab3a1-914f-545c-fc32-ae63602413f8@gmail.com> (raw)
In-Reply-To: <20201004161257.13945-2-andrew@lunn.ch>
On 10/4/2020 9:12 AM, Andrew Lunn wrote:
> Not all ports of a switch need to be used, particularly in embedded
> systems. Add a port flavour for ports which physically exist in the
> switch, but are not connected to the front panel etc, and so are
> unused. By having unused ports present in devlink, it gives a more
> accurate representation of the hardware. It also allows regions to be
> associated to such ports, so allowing, for example, to determine
> unused ports are correctly powered off, or to compare probable reset
> defaults of unused ports to used ports experiences issues.
>
> Actually registering unused ports and setting the flavour to unused is
> optional. The DSA core will register all such switch ports, but such
> ports are expected to be limited in number. Bigger ASICs may decide
> not to list unused ports.
>
> v2:
> Expand the description about why it is useful
>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> Tested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-10-04 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 16:12 [PATCH net-next v3 0/7] mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-10-04 16:12 ` [PATCH net-next v3 1/7] net: devlink: Add unused port flavour Andrew Lunn
2020-10-04 16:17 ` Florian Fainelli [this message]
2020-10-04 16:12 ` [PATCH net-next v3 2/7] net: dsa: Make use of devlink port flavour unused Andrew Lunn
2020-10-04 16:18 ` Florian Fainelli
2020-10-04 16:12 ` [PATCH net-next v3 3/7] net: dsa: Register devlink ports before calling DSA driver setup() Andrew Lunn
2020-10-04 16:21 ` Florian Fainelli
2020-10-04 20:55 ` Vladimir Oltean
2020-10-04 16:12 ` [PATCH net-next v3 4/7] net: devlink: Add support for port regions Andrew Lunn
2020-10-04 16:12 ` [PATCH net-next v3 5/7] net: dsa: Add devlink port regions support to DSA Andrew Lunn
2020-10-04 16:23 ` Florian Fainelli
2020-10-04 16:12 ` [PATCH net-next v3 6/7] net: dsa: Add helper for converting devlink port to ds and port Andrew Lunn
2020-10-04 16:23 ` Florian Fainelli
2020-10-04 21:02 ` Vladimir Oltean
2020-10-04 16:12 ` [PATCH net-next v3 7/7] net: dsa: mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-10-04 16:24 ` Florian Fainelli
2020-10-04 21:07 ` Vladimir Oltean
2020-10-04 21:39 ` [PATCH net-next v3 0/7] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb6ab3a1-914f-545c-fc32-ae63602413f8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).