From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C6BC43381 for ; Tue, 26 Mar 2019 02:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 708B920823 for ; Tue, 26 Mar 2019 02:24:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bnr953aR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731026AbfCZCYz (ORCPT ); Mon, 25 Mar 2019 22:24:55 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39589 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727157AbfCZCYz (ORCPT ); Mon, 25 Mar 2019 22:24:55 -0400 Received: by mail-pg1-f195.google.com with SMTP id k3so3802674pga.6 for ; Mon, 25 Mar 2019 19:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bGnIY+vz1KqrASo4p2N9NZ9GxjcT/gfhwigF4DKU7Kk=; b=bnr953aRt9Jpq1Qz2MgFAEt06C7zakMCyY9p+/gF1PQIWsuXp8HhJ91K5TuvgXYujx OnrixqHSQ+rva26Ub/77q+UCca3+1PCIlq7fOQmSwq9oJPK0i5K5ayEuJ09tW3aUxSsO SgP5G1ox4wAZFrHH3Wi+eb+MOArsKDVJWwJ8osmOiYibNWn9VvinccsSqLENpi4FNAxa uSP1OncrMX7rmWPiRFdNwxVxndmbFOfCyS0dEI4/f4efnDJpOHgMwL9CcMGrDrtfe7Wr 5pZfbQLMn8kb7cqQUeXU0KdrqgEUfopolnW/JxDCWWrTNz5tBMtfPEeh5ZzT0xdU1raH E21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bGnIY+vz1KqrASo4p2N9NZ9GxjcT/gfhwigF4DKU7Kk=; b=PRdtQVLUc3qrs9bbbFfTkMksibQsWRHHzUcM+N+5gXtBRc3+WrRsn00V24ebMYF07o yQUzXJz2VHi25pbtuI5nHTj1+12IFBNWNdY1sEroHEBnrMVV5WIxajjlvdk3b9FmSBFA ammp2c3uWlPFJnTkUaxAmNZdlET1a7tzqKqc8Qx6+xSZU6bcH60iSLUXZxBJcRkputKx NdVKIEpxI5jDtnDsxT+U54bDg9qPIYimlXUTac7rgPj6LC/zagAo4HRLtMY8vKtgVb+5 Zr8mQzxznBFtR9wI4xwWp+zJyIYE6TqpPhaRkroyHuNzDZSsGKFYU+6mm87DrAFNIfhA FXzA== X-Gm-Message-State: APjAAAVqnYwiFWrtQk2SQg/6jgY8fnuGaip9W8+vSWq2bwO4PeEQEk82 Z8+TW5xHQCgYSbPYiMIKyRc= X-Google-Smtp-Source: APXvYqydvE2yNQif+aBXZUIuGOc1aOZMaHEvZdJjXcYj7f96UaMKffB2T3MLt6EKxKZlbjt+p2SKnQ== X-Received: by 2002:a63:2aca:: with SMTP id q193mr26688926pgq.269.1553567094273; Mon, 25 Mar 2019 19:24:54 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id z6sm25930392pfz.65.2019.03.25.19.24.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 19:24:53 -0700 (PDT) Subject: Re: [RFC PATCH net-next 13/13] dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver To: Vladimir Oltean , davem@davemloft.net, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, linus.walleij@linaro.org References: <20190324032346.32394-1-olteanv@gmail.com> <20190324032346.32394-14-olteanv@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: Date: Mon, 25 Mar 2019 19:24:51 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190324032346.32394-14-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > Signed-off-by: Vladimir Oltean > --- > .../devicetree/bindings/net/dsa/sja1105.txt | 123 ++++++++++++++++++ > 1 file changed, 123 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/dsa/sja1105.txt > > diff --git a/Documentation/devicetree/bindings/net/dsa/sja1105.txt b/Documentation/devicetree/bindings/net/dsa/sja1105.txt > new file mode 100644 > index 000000000000..2c82b6fc37e3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/dsa/sja1105.txt > @@ -0,0 +1,123 @@ > +NXP SJA1105 switch driver > +========================= > + > +Required properties: > + > +- compatible: Must be "nxp,sja1105". Device ID identification (one of > + E/T/P/Q/R/S) is performed by driver at probe time. Swapping pin-compatible > + parts is possible with no DTS change. > + > +Optional properties: > + > +- sja1105,mac-mode, sja1105,phy-mode: Boolean properties that can be assigned > + under each port node that is MII or RMII (has no effect for RGMII). By > + default (unless otherwise specified) a port is configured as MAC if it is > + driving a PHY (phy-handle is present) or as PHY if it is PHY-less (fixed-link > + specified, presumably because it is connected to a MAC). These properties > + are required in the case where SJA1105 ports are at both ends of an MII/RMII > + PHY-less setup. One end would need to have sja1105,mac-mode, while the other > + sja1105,phy-mode. Typically we would be using a fixed-link with an appropriate 'phy-mode' property to describe a MAC to MAC connection, this may be seen as a re-purposing PHY-oriented properties though, so I am fine with that binding: Reviewed-by: Florian Fainelli -- Florian