From: Paolo Abeni <pabeni@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Wen Gu <guwen@linux.alibaba.com>,
Philo Lu <lulie@linux.alibaba.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Dong Yibo <dong100@mucse.com>,
Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vivian Wang <wangruikang@iscas.ac.cn>,
Dust Li <dust.li@linux.alibaba.com>
Subject: Re: [PATCH net-next v35 0/8] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor
Date: Thu, 26 Mar 2026 12:26:33 +0100 [thread overview]
Message-ID: <cb8280ad-fd08-4201-9faa-d8b1bc4f0bd7@redhat.com> (raw)
In-Reply-To: <20260323074441.91691-1-xuanzhuo@linux.alibaba.com>
On 3/23/26 8:44 AM, Xuan Zhuo wrote:
> Add a driver framework for EEA that will be available in the future.
>
> This driver is currently quite minimal, implementing only fundamental
> core functionalities. Key features include: I/O queue management via
> adminq, basic PCI-layer operations, and essential RX/TX data
> communication capabilities. It also supports the creation,
> initialization, and management of network devices (netdev). Furthermore,
> the ring structures for both I/O queues and adminq have been abstracted
> into a simple, unified, and reusable library implementation,
> facilitating future extension and maintenance.
Unfortunately sashiko fund more stuff:
https://sashiko.dev/#/patchset/20260323074441.91691-1-xuanzhuo%40linux.alibaba.com
AFAIK checks vs malicious values from the H/W are not due, but stats
endianness, 32-bits, truesize related concerns looks real.
As for the acceptance criteria, we should not merge code with known
issues. A problem with this driver submission is the size and complexity
which allow LLMs to dig different things at different moments.
/P
next prev parent reply other threads:[~2026-03-26 11:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 7:44 [PATCH net-next v35 0/8] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 1/8] eea: introduce PCI framework Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 2/8] eea: introduce ring and descriptor structures Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 3/8] eea: probe the netdevice and create adminq Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 4/8] eea: create/destroy rx,tx queues for netdevice open and stop Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 5/8] eea: implement packet receive logic Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 6/8] eea: implement packet transmit logic Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 7/8] eea: introduce ethtool support Xuan Zhuo
2026-03-23 7:44 ` [PATCH net-next v35 8/8] eea: introduce callback for ndo_get_stats64 Xuan Zhuo
2026-03-26 11:26 ` Paolo Abeni [this message]
2026-03-26 11:38 ` [PATCH net-next v35 0/8] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2026-03-26 12:06 ` Paolo Abeni
2026-03-26 12:11 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8280ad-fd08-4201-9faa-d8b1bc4f0bd7@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=guwen@linux.alibaba.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox