From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] inet: frags: better deal with smp races
Date: Thu, 8 Nov 2018 17:31:41 -0800
Message-ID: <cba091d5-826a-98ab-87a6-c1eeca0afe20@gmail.com>
References: <20181108061053.137720-1-edumazet@google.com>
 <20181108.170235.1217371124928853665.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-7
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
        soukjin.bae@samsung.com
To: David Miller <davem@davemloft.net>, edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f196.google.com ([209.85.214.196]:33485 "EHLO
        mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726929AbeKILKB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Nov 2018 06:10:01 -0500
Received: by mail-pl1-f196.google.com with SMTP id w22-v6so154475plk.0
        for <netdev@vger.kernel.org>; Thu, 08 Nov 2018 17:31:43 -0800 (PST)
In-Reply-To: <20181108.170235.1217371124928853665.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 11/08/2018 05:02 PM, David Miller wrote:

> GCC is unwilling to see that all paths leading to that final return
> statement do in fact set 'fq' one way or another:
> 
> net/ipv4/inet_fragment.c: In function ˇinet_frag_find˘:
> net/ipv4/inet_fragment.c:224:9: warning: ˇfq˘ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> This is with:
> 
> gcc (GCC) 8.2.1 20181011 (Red Hat 8.2.1-4)
> 
> Please adjust your patch so that the warning is eliminated.
> 

Interesting, I will init *fq to NULL in v2, thanks.