From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794346502; b=ydfUfiyF4WdPkisdvpUVWMs2Kk9Vld+JzJd3miPWOZiK75knzf3ulCcZLKDW8ZYPmWQQ c1o7FtqW7PIc5vu+yWxfxbwMq9HToLapXNBhH+Mc67gve1VbokEXZETfBH74a60TDyDhX jg4JajP3424ewNewQPS27hVIIcXuc62056ccEZPnV+2FU917bIJ+7N/pssw0l4HlZgXwr Fgz/Fp0pZvR5TdX60YPFRJi+o6MBtNkXDB0hifRS492D1aNqI9HI4ugr2WoVhf3OXWSE1 AQua4p3Fjc5OrwwusrEconab+Ycf3wH3eAnIZuPSaMEcnzKBVikkVxsKxu9RuPMWFgQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794346502; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=mOqbf5f8IOrYsXobBY3T9L29gUMiYe3oysuU/ey3bJU=; b=5suLR6Rgf5vkCGa1YVppXX/OEQCaTtB7Vr0AE0x2oKWOtsDpYjYAbHuvZpo0skF3Wk/y 6PlcgvUysyGhjkaVhtgrIkzL1m6EV58kUn8SD3hbKkpZOV6IqTCUPXCygpZd9eW+DK4q3 AibJwsz7x9RHM693Wd7ODgjmS8vBCzIVE6ceN2MO2PhK0UlDS1GLpkeYH6nBpC3OdPftZ IKkkaVBnskQYUKoZSp43tKqj1cYLK89kHiMHsPiv4pImFyHAxtSGsADE0FBc+qZgRj/5n 4nRfQGAJ68OvGGvpclyd5lzn6LI8jnpprsRHZOnG0v2Z+1wxSiFcjdoxhs3UPg7tu0w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=cQ5xwQ6H; arc=none smtp.remote-ip=209.85.221.42 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13872606A32A for ; Tue, 10 Nov 2026 21:35:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 13872606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=cQ5xwQ6H Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-48e1d0e5dafso1705379f8f.1 for ; Tue, 10 Nov 2026 13:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794346500; x=1794951300; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mOqbf5f8IOrYsXobBY3T9L29gUMiYe3oysuU/ey3bJU=; b=cQ5xwQ6HxvcHCdVO4r6Zx1QKFnlw5WLHnAF1G9hPEgTyBn03UOrvZjE9idlHwO1Ry9 Ua4VMMAmZ4MUqxSKUEOgOuNZ8EZlSYLFOQjjxypNvGBlSnE00SnaVz/OC3Yd/f/JKk3d ixozxVkn48kkO2fGlEyzbhH2W2i842magCGSlXzocmY234qZXqjWwV7fXieUZgClA0Fk YKBkqZje0zuORPfMlu7J2D8lQ2b+Dg4ZUacCiwBh8g9bF129dWhdYYppNulvfYEBvGbV 0igXXgKVF8NZwyyzVntYU55XI+ye345Kd4eCvg/S9bVkz95mzJRfifF8IZHZaI69Klde HUPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794346500; x=1794951300; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mOqbf5f8IOrYsXobBY3T9L29gUMiYe3oysuU/ey3bJU=; b=eFpKEi0ihEqvhBtO+Yr2F4gXMtWO3pmxDVR0sPJQP8yOZglW9N8OdaYCX/7bdhjCim gKWwB6jZ8EawXwf2hRbaitr7cPopPfTryX4U40rluRl9sNJ6BV8dA9ykhi5oz7nKCSEr AfegDaoztPNdexhpDVgMi2nbBFaHF4Fk/8+Tu9CDITcYSw2Hs4Sd3mZkGnP8+Lb3YXy8 66wTcuhBUdhVcT42jlcih4rXR/C5A5IGvFgsR3CeFPf79AqItXI2YBtPjCJrQpcLKmum sPDjhXdccjMNbnR8crnb5DRPxIyVowb1VV2g4CuZf3Fhq0qsZt/R2ulLSOKvK7Fe+K1F 4sBg== X-Forwarded-Encrypted: i=1; AL+hErFrS2XcZ++kSNclL7D5AXPdeQauC6EmMy4zC1cAx5mnczHPupjPcaCC1mMCTB+G0Hwb+GmKmDk=@vger.kernel.org X-Gm-Message-State: APuU4Z/rIIXaacuIk/QP+94p4Y73oxnM8p6X1pa3SPc4Z8co9Dp33P9f Z+pQ4bbRgRyKPIybsJXy0LCxMmKwdj6J0QGI5cQFJSt0uV5vx2RM75KO X-Gm-Gg: AYBFou2IepPIAF05Ng/I5SGuejT68y7xSB130vyfKnDiT4Lb5Llwmrzp2tNu5h75F+Q iJVmvn0jz/Rio17BdaOzKWBqhzhiMFMnuXYZcNyUnQF81sh+a6KsbBiHiLjnklHnpJh9aXjkGeg SmC42iD1dXugxOla1ZyCc9QJTFl4YBPGy5ZS4/pkFpMB0cr68qyXe2ps1XROA3AOksttvMvJf+X c1TqapghcAlccoAArdMqHgf8SrRVBmM6E6oVWEihoTZcbps7jS1AKpRVgy2wOiPs2Ah1OXSa8ZR +bpdPAd14Ml4C15gpG8w+mq36E0YVDEFzJvJyiGo7skpBQaSmZG+ArXOwm3Ay261Tdpxttft7vT jhBDxYs7mxZYM0Jl70p1twDZOb0eTP5TjCYol+tbzNqLE5dvWAgso6058SAcmrBx0asAhjj9OKT AkP5IZDhU3S6IhkDt3pwM/DAzBW+AwldEVg2gOEgnFoDOOgmLJKIbv1EVVSQIZQl3pxmhsvqJjk t7DoT9eFkraOyvKN7QCx3qrPi3j+9zobJHjUY3LKFs4Bev9ancyG2A69SV+LMRw5bBHOH9RSsDF UzGfGkx3FrXixqdI3ebRV1E3 X-Received: by 2002:a05:600c:364b:b0:4a1:d766:758 with SMTP id 5b1f17b1804b1-4ba08e1f572mr8423245e9.16.1794346500171; Tue, 10 Nov 2026 13:35:00 -0800 (PST) Received: from [192.168.1.22] ([83.231.69.9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-498369a3fd2sm7670526f8f.52.2026.11.10.13.34.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2026 13:34:59 -0800 (PST) Message-ID: Date: Tue, 10 Nov 2026 22:34:55 +0100 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/9] mm: limit pagecache folio refcount when splicing into pipes To: "David Hildenbrand (Arm)" , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Peter Xu , Johannes Weiner , Song Liu , Rik van Riel , Miklos Szeredi , Alexander Viro , Christian Brauner , Hugh Dickins , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Jason Gunthorpe , Kevin Tian , "Joerg Roedel (AMD)" , Robin Murphy , Steve Sistare , John Hubbard , Josef Bacik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Neal Cardwell , Kuniyuki Iwashima , Linus Torvalds Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, fuse-devel@lists.linux.dev, linux-arch@vger.kernel.org, iommu@lists.linux.dev, netdev@vger.kernel.org, stable@vger.kernel.org References: <20261110-refcount_overflow_stable-v3-0-318625d63a98@kernel.org> <20261110-refcount_overflow_stable-v3-2-318625d63a98@kernel.org> Content-Language: en-US From: "Jose A. Perez de Azpillaga" In-Reply-To: <20261110-refcount_overflow_stable-v3-2-318625d63a98@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/10/26 9:35 PM, David Hildenbrand (Arm) wrote: > Similar to mapping pagecache folios into page tables, let's reject > additional references when splicing folios into a pipe if the refcount > is at its limit, similar to how we handle it during GUP. > > This will prevent more cases of possible folio refcount overflows with > large pagecache folios. > > Introduce folio_get_checked() for checked reference acquisition when > the caller already holds a reference. It warns and fails on a non-positive > refcount and rejects additional references at the limit. > > Use folio_get_checked() in splice_folio_into_pipe() and > fuse_ref_folio(), returning -EFAULT on failure, like we already do for > pipe-buffer duplication. Similarly, make try_get_page() use it instead. > > Likely try_get_page() should be renamed (or removed) later, as it doesn't > match the folio_try_get() semantics and is confusing. > > If we hit the limit after splicing some data, return the number of bytes > already spliced. Teach the callers to handle errors, and stop > filemap_splice_read() if we only spliced part of a folio, so we don't > skip ahead to the next folio. > > The check in try_get_page() also covers pipe-buffer duplication by tee() > and partial pipe-to-pipe splicing. > > Note that we deliberately will not fall back to the slow path of copying > the folio, particularly as the folio might have an invalid refcount. If > it is ever really required, we can revisit. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") > Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) LGTM :) Reviewed-by: Jose A. Perez de Azpillaga -- cheers, jose a. p-a