From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263AAC10F11 for ; Wed, 10 Apr 2019 19:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5DA32070D for ; Wed, 10 Apr 2019 19:31:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bpcWEXeh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726577AbfDJTbd (ORCPT ); Wed, 10 Apr 2019 15:31:33 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34733 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbfDJTbc (ORCPT ); Wed, 10 Apr 2019 15:31:32 -0400 Received: by mail-wr1-f67.google.com with SMTP id p10so4338535wrq.1 for ; Wed, 10 Apr 2019 12:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FD9AgKNR18+X4PUuPx4inEFPRV7yM/smMVLRjglizOo=; b=bpcWEXeh3w1GmulPOVtc/awBxMhzABfbBx1+jU4E666frhRErMOJHw3ePn3i6spR5G tzLo4TA5GuN0PJd1VVSJqLzSiQ93nW/pVG2YZTVDgtv8JRcQwyDIn8RHZf/LKn56mPAr 0cau/9H3HvFf+EggjQgye88y0j1Q1UlhHiXi2k3SyE6b8uWjswzNPhclzNOJfa264vBt vIs9+Ln8k6+O/D4n7letF+0tYg1b4y6c8kEvLErtpA6YJ/FqJ8+RgBj8D6/PrHV0Gnsk RxesYQeH1pBhPU7nyQ5K+Ft/53qElcbEJgseKAkmy+ppcN5uKwT9V7wbQfUvdGkpID0L BeqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FD9AgKNR18+X4PUuPx4inEFPRV7yM/smMVLRjglizOo=; b=lvnnlJLN3L7vxjE6ZQ9Jo+JLTPMXm3seaQde4tUDd/oOHl6I9LYOzX97YJm9aI9mqX 3YGPmaBjL81E9Mgy/xgxr0QrnKH+EeyOoeGWeIu5Eo1pUIBVPdxzTielyQxpeX5ObzRA qWcnoJfHvHZnbhKzfT4izvPLoHXYRScjyuj3Q4GNrsNCAyLCg3Qj9jieLSG1NChLPEEn mSAY1Jv1gIxOB+p3WFx6FMeUJjRAZAH4LfGhT2rz0bnpToq+8hUF2yu7wdTTyxi4AXfM 8HDKwSXnBjriJ5TLuWvvrKI8tdndahT7p5g71PD5XyVQ6gxjzCjs1zeaQA8ZZGsx3F0Z m3eA== X-Gm-Message-State: APjAAAXvxVjgsE9QMNrcUzWwDndzgnXIDs9HD4EU5gD9VGm2lW+ENe9Q igDWATqLfEUtzcoezhBOrtA= X-Google-Smtp-Source: APXvYqwoeyN9+UooelYtNhtA937+OzNXrHhn47ktOWQVlHOUDZ7RTrHA/o6PAC5h7Cy6L8wNyBTwmQ== X-Received: by 2002:adf:fc0b:: with SMTP id i11mr10274286wrr.145.1554924690706; Wed, 10 Apr 2019 12:31:30 -0700 (PDT) Received: from ?IPv6:2003:ea:8bde:d800:c461:eb2c:a778:e64a? (p200300EA8BDED800C461EB2CA778E64A.dip0.t-ipconnect.de. [2003:ea:8bde:d800:c461:eb2c:a778:e64a]) by smtp.googlemail.com with ESMTPSA id o1sm4220698wmh.47.2019.04.10.12.31.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 12:31:29 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection To: David Miller , f.fainelli@gmail.com Cc: andrew@lunn.ch, rjui@broadcom.com, sbranden@broadcom.com, richardcochran@gmail.com, khilman@baylibre.com, heiko@sntech.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> <20190409.135944.1516944884952068835.davem@davemloft.net> From: Heiner Kallweit Message-ID: Date: Wed, 10 Apr 2019 21:31:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409.135944.1516944884952068835.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09.04.2019 22:59, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 7 Apr 2019 11:57:13 +0200 > >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones with basic features sets, i.e. >> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these >> features explicitly and rely on phylib feature detection. >> >> I don't have access to most of these PHY's, therefore I'd appreciate >> regression testing. >> >> Signed-off-by: Heiner Kallweit > > This appears to need to be done differently. > > A question was asked as to why fast ethernet PHY identification from the > source is important, well I'd say it's important for someone working on > the PHY code to see how "all fast ethernet PHY drivers do or handle X" > Then, what we could do: Change all occurrences of .features = PHY_XXX_FEATURES to /* PHY_XXX_FEATURES */ Would this be an acceptable option? > :-) >