From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Dinh Nguyen <dinguyen@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
joabreu@synopsys.com, Wei Liang Lim <wei.liang.lim@intel.com>
Subject: Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode
Date: Wed, 15 May 2019 09:18:15 -0700 [thread overview]
Message-ID: <cbe79f88-2f4c-a5bc-7dcd-e1dac253a787@gmail.com> (raw)
In-Reply-To: <20190515152407.GA24455@lunn.ch>
On 5/15/19 8:24 AM, Andrew Lunn wrote:
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct socfpga_dwmac *dwmac)
>> case PHY_INTERFACE_MODE_SGMII:
>> val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
>> break;
>> + case PHY_INTERFACE_MODE_RMII:
>> + val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
>> + break;
>
> What about PHY_INTERFACE_MODE_RMII_ID, PHY_INTERFACE_MODE_RMII_RXID,
> PHY_INTERFACE_MODE_RMII_TXID?
RMII is reduced MII not Reduced Gigabit MII (RGMII), which still
operates at MII speed, therefore no concept of internal deal for RX/TX
data lines, the change looks fine to me.
--
Florian
next prev parent reply other threads:[~2019-05-15 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 14:46 [PATCH net-next] net: stmmac: socfpga: add RMII phy mode Dinh Nguyen
2019-05-15 15:24 ` Andrew Lunn
2019-05-15 16:18 ` Florian Fainelli [this message]
2019-05-15 16:30 ` Andrew Lunn
2019-05-15 16:18 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbe79f88-2f4c-a5bc-7dcd-e1dac253a787@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dinguyen@kernel.org \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liang.lim@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).