public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Benjamin Poirier <bpoirier@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>,
	Jakub Kicinski <kuba@kernel.org>, Kevin Hao <haokexin@gmail.com>,
	Liang Chen <liangchen.linux@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] pktgen: Use seq_putc() in pktgen_if_show()
Date: Sun, 14 Jul 2024 20:34:14 +0200	[thread overview]
Message-ID: <cc21bbb8-e6d3-4670-9d39-f5db0f27f8ce@web.de> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 14 Jul 2024 20:23:49 +0200

Single line breaks should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/core/pktgen.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index ea55a758a475..441e058d6726 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -577,7 +577,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v)
 				   pkt_dev->imix_entries[i].size,
 				   pkt_dev->imix_entries[i].weight);
 		}
-		seq_puts(seq, "\n");
+		seq_putc(seq, '\n');
 	}

 	seq_printf(seq,
@@ -685,7 +685,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v)
 		}
 	}

-	seq_puts(seq, "\n");
+	seq_putc(seq, '\n');

 	/* not really stopped, more like last-running-at */
 	stopped = pkt_dev->running ? ktime_get() : pkt_dev->stopped_at;
@@ -706,7 +706,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v)
 				   pkt_dev->imix_entries[i].size,
 				   pkt_dev->imix_entries[i].count_so_far);
 		}
-		seq_puts(seq, "\n");
+		seq_putc(seq, '\n');
 	}

 	seq_printf(seq,
--
2.45.2


             reply	other threads:[~2024-07-14 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-14 18:34 Markus Elfring [this message]
2024-07-16 13:29 ` [PATCH] pktgen: Use seq_putc() in pktgen_if_show() Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc21bbb8-e6d3-4670-9d39-f5db0f27f8ce@web.de \
    --to=markus.elfring@web.de \
    --cc=Ilia.Gavrilov@infotecs.ru \
    --cc=agruenba@redhat.com \
    --cc=bpoirier@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=haokexin@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=liangchen.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox