From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter
Date: Mon, 21 May 2018 11:08:57 -0700
Message-ID: <cc55420f-e5c4-c699-7af9-ff273487ef18@gmail.com>
References: <152691970035.4083.3349902669266371765.stgit@alrua-kau>
 <152691985736.4083.3416150561524698541.stgit@alrua-kau>
 <f7a7917b-9d81-b192-514b-3861321a4892@gmail.com> <87r2m4ykrc.fsf@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org,
        cake@lists.bufferbloat.net
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f52.google.com ([74.125.83.52]:38343 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753237AbeEUSI7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 21 May 2018 14:08:59 -0400
Received: by mail-pg0-f52.google.com with SMTP id n9-v6so6693034pgq.5
        for <netdev@vger.kernel.org>; Mon, 21 May 2018 11:08:59 -0700 (PDT)
In-Reply-To: <87r2m4ykrc.fsf@toke.dk>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 05/21/2018 10:35 AM, Toke Høiland-Jørgensen wrote:

> Ah yes, sequence number wrapping. I was thinking I needed to deal with
> that, and then got sidetracked and forgot about it. Will fix.
> 
> Other than that, do you agree that this approach to SACK and header
> handling can work?

Unfortunately this does not handle dsack (RFC 2883, and  3708) properly, I believe.