From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nambiar, Amritha" Subject: Re: [net-next PATCH v5 1/7] net: Refactor XPS for CPUs and Rx queues Date: Sat, 30 Jun 2018 00:48:53 -0700 Message-ID: References: <153013824922.4959.14633065530326138344.stgit@anamhost.jf.intel.com> <153013867798.4959.5260718966225816154.stgit@anamhost.jf.intel.com> <20180629.215938.2008552830198656487.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, alexander.h.duyck@intel.com, willemdebruijn.kernel@gmail.com, sridhar.samudrala@intel.com, alexander.duyck@gmail.com, edumazet@google.com, hannes@stressinduktion.org, tom@herbertland.com, tom@quantonium.net To: David Miller Return-path: Received: from mga11.intel.com ([192.55.52.93]:63331 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494AbeF3HtA (ORCPT ); Sat, 30 Jun 2018 03:49:00 -0400 In-Reply-To: <20180629.215938.2008552830198656487.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/29/2018 5:59 AM, David Miller wrote: > From: Amritha Nambiar > Date: Wed, 27 Jun 2018 15:31:18 -0700 > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index c6b377a..3790ac9 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h > ... >> +static inline bool attr_test_online(unsigned long j, >> + const unsigned long *online_mask, >> + unsigned int nr_bits) > > This is a networking header file, so for names you are putting into > the global namespace please give them some kind of prefix that > indicates it is about networking. > Sure, will prefix these with 'netif_'.