From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: <jeff.evanson@gmail.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Vedang Patel <vedang.patel@intel.com>,
Andre Guedes <andre.guedes@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Jithu Joseph <jithu.joseph@intel.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Jeff Evanson <jeff.evanson@qsc.com>
Subject: Re: [PATCH v2 2/2] igc: Trigger proper interrupts in igc_xsk_wakeup
Date: Thu, 21 Apr 2022 13:23:53 -0700 [thread overview]
Message-ID: <ccb8e7f0-c038-c525-0902-47c321c19a10@intel.com> (raw)
In-Reply-To: <20220420012635.13733-3-jeff.evanson@qsc.com>
On 4/19/2022 6:26 PM, jeff.evanson@gmail.com wrote:
> From: Jeff Evanson <jeff.evanson@qsc.com>
>
> In igc_xsk_wakeup, trigger the proper interrupt based on whether flags
> contains XDP_WAKEUP_RX and/or XDP_WAKEUP_TX.
>
> Consider a scenario where the transmit queue interrupt is mapped to a
> different irq from the receive queue. If XDP_WAKEUP_TX is set in the
> flags argument, the interrupt for transmit queue must be triggered,
> otherwise the transmit queue's napi_struct will never be scheduled.
>
> In the case where both XDP_WAKEUP_TX and XDP_WAKEUP_RX are both set,
> the receive interrupt should always be triggered, but the transmit
> interrupt should only be triggered if its q_vector differs from the
> receive queue's interrupt.
>
> Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")
You're missing your sign-off; same for patch 1. Also, there's a handful
of issues being reported by checkpatch [1]
Thanks,
Tony
[1]
https://patchwork.kernel.org/project/netdevbpf/patch/20220420012635.13733-3-jeff.evanson@qsc.com/
prev parent reply other threads:[~2022-04-21 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 1:26 [PATCH v2 0/2] AF_XDP patches for zero-copy in igc driver jeff.evanson
2022-04-20 1:26 ` [PATCH v2 1/2] igc: Fix race in igc_xdp_xmit_zc jeff.evanson
2022-04-20 1:26 ` [PATCH v2 2/2] igc: Trigger proper interrupts in igc_xsk_wakeup jeff.evanson
2022-04-21 20:23 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccb8e7f0-c038-c525-0902-47c321c19a10@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=andre.guedes@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeff.evanson@gmail.com \
--cc=jeff.evanson@qsc.com \
--cc=jesse.brandeburg@intel.com \
--cc=jithu.joseph@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox