From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [RFC PATCH 05/10] net: dsa: mv88e6xxx: add support for GPIO configuration Date: Sun, 4 Feb 2018 11:53:58 -0800 Message-ID: References: <1517694016-6692-1-git-send-email-andrew@lunn.ch> <1517694016-6692-6-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Vivien Didelot , sean.wang@mediatek.com, Woojung.Huh@microchip.com, john@phrozen.org, jbe@pengutronix.de, richardcochran@gmail.com, Brandon Streiff To: Andrew Lunn , netdev Return-path: Received: from mail-ot0-f193.google.com ([74.125.82.193]:41690 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbeBDTyD (ORCPT ); Sun, 4 Feb 2018 14:54:03 -0500 Received: by mail-ot0-f193.google.com with SMTP id r23so23596457ote.8 for ; Sun, 04 Feb 2018 11:54:03 -0800 (PST) In-Reply-To: <1517694016-6692-6-git-send-email-andrew@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 02/03/2018 01:40 PM, Andrew Lunn wrote: > From: Brandon Streiff > > MV88E6352 and later switches support GPIO control through the "Scratch > & Misc" global2 register. (Older switches do too, though with a slightly > different register interface. Only the 6352-style is implemented here.) > > Add a new file, global2_scratch.c, for operations in the Scratch & Misc > space. Additionally, add a GPIO operations structure to present an > abstract view over GPIO manipulation. > > Reverse Christmas tree and unsigned has been replaced with unsigned > int by Andrew Lunn. I thought one of the comments made on Brian's original submission was to expose GPIO pins as a proper gpiochip which incidentally might help with GPIOs on the switch being used for other purposes (e.g; LEDs, etc.), is that an option here? -- Florian