From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
stephen@networkplumber.org, dsahern@gmail.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH iproute2-next] tc: q_netem: JSON-ify the output
Date: Fri, 21 Jun 2019 16:52:15 -0600 [thread overview]
Message-ID: <cd06748a-5d75-13a6-ba6c-434fc600b53d@gmail.com> (raw)
In-Reply-To: <20190614172817.14817-1-jakub.kicinski@netronome.com>
On 6/14/19 11:28 AM, Jakub Kicinski wrote:
> Add JSON output support to q_netem.
>
> The normal output is untouched.
>
> In JSON output always use seconds as the base of time units,
> and non-percentage numbers (0.01 instead of 1%). Try to always
> report the fields, even if they are zero.
> All this should make the output more machine-friendly.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
> ---
> tc/q_netem.c | 174 +++++++++++++++++++++++++++++++--------------------
> 1 file changed, 107 insertions(+), 67 deletions(-)
>
applied to iproute2-next. Thanks
prev parent reply other threads:[~2019-06-21 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 17:28 [PATCH iproute2-next] tc: q_netem: JSON-ify the output Jakub Kicinski
2019-06-21 22:52 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd06748a-5d75-13a6-ba6c-434fc600b53d@gmail.com \
--to=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox